From: Nicolai Fischer <nicolai.fischer@fau.de>
To: Joe Perches <joe@perches.com>, linux-kernel@vger.kernel.org
Cc: apw@canonical.com, johannes.czekay@fau.de, linux-kernel@i4.cs.fau.de
Subject: Re: [PATCH 2/2] checkpatch: kconfig: add missing types to regex
Date: Mon, 21 Dec 2020 16:08:11 +0100 [thread overview]
Message-ID: <5d7cef4f-071d-0504-74df-bd944a11dd70@fau.de> (raw)
In-Reply-To: <1f3b50a6f343dd252c043b2e5b7d47bca8514ee7.camel@perches.com>
On Sun, 2020-12-20 at 20:16 +0100, Joe Perches wrote:
> On Mon, 2020-12-14 at 11:24 +0100, Nicolai Fischer wrote:
>> Kconfig parsing does not recognise all type attributes.
>> This adds the missing 'int', 'sting' and 'hex' types.
> []
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
>> @@ -3321,7 +3321,7 @@ sub process {
>> next if ($f =~ /^-/);
>> last if (!$file && $f =~ /^\@\@/);
>>
>>
>> - if ($lines[$ln - 1] =~ /^\+\s*(?:bool|tristate|prompt)\s*["']/) {
>> + if ($lines[$ln - 1] =~ /^\+\s*(?:bool|tristate|int|hex|string|prompt)\s*["']/) {
>> $is_start = 1;
>> } elsif ($lines[$ln - 1] =~ /^\+\s*help$/) {
>> $length = -1;
>
> Another thing that could be done is to enforce the "extra 2 spaces"
> indent by capturing the whitespace before the help keyword:
>
> } elsif ($lines[$ln - 1] =~ /^\+\s*help$/) {
>
> could be
>
> } elsif ($lines[$ln - 1] =~ /^\+(\s*)help\s*$/) {
>
> with $1 used to validate the extra indent.
>
>
In case the indent does not match, should we display a new warning as in our previous patch?
On Tue, 2020-12-08 at 14:35 +0100, Nicolai Fischer wrote> + WARN("CONFIG_DESCRIPTION",
> + "help text is not indented 2 spaces more than the help keyword\n" . $herecurr);
next prev parent reply other threads:[~2020-12-21 15:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 10:24 [PATCH 2/2] checkpatch: kconfig: add missing types to regex Nicolai Fischer
2020-12-20 19:12 ` Joe Perches
2020-12-20 19:16 ` Joe Perches
2020-12-21 15:08 ` Nicolai Fischer [this message]
2020-12-21 17:17 ` Joe Perches
2020-12-25 17:27 ` Nicolai Fischer
2020-12-25 17:42 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d7cef4f-071d-0504-74df-bd944a11dd70@fau.de \
--to=nicolai.fischer@fau.de \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=johannes.czekay@fau.de \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).