[PATCH] sched/psi.c: Rudimentary typo fixes

[PATCH] sched/psi.c: Rudimentary typo fixes

[Bhaskar Chowdhury]

s/possible/possible/
s/ exceution/execution/
s/manupulations/manipulations/

Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
 kernel/sched/psi.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
index 967732c0766c..316ebc57a115 100644
--- a/kernel/sched/psi.c
+++ b/kernel/sched/psi.c
@@ -59,7 +59,7 @@
  * states, we would have to conclude a CPU SOME pressure number of
  * 100%, since *somebody* is waiting on a runqueue at all
  * times. However, that is clearly not the amount of contention the
- * workload is experiencing: only one out of 256 possible exceution
+ * workload is experiencing: only one out of 256 possible execution
  * threads will be contended at any given time, or about 0.4%.
  *
  * Conversely, consider a scenario of 4 tasks and 4 CPUs where at any
@@ -73,7 +73,7 @@
  * we have to base our calculation on the number of non-idle tasks in
  * conjunction with the number of available CPUs, which is the number
  * of potential execution threads. SOME becomes then the proportion of
- * delayed tasks to possibe threads, and FULL is the share of possible
+ * delayed tasks to possible threads, and FULL is the share of possible
  * threads that are unproductive due to delays:
  *
  *	threads = min(nr_nonidle_tasks, nr_cpus)
@@ -441,7 +441,7 @@ static void psi_avgs_work(struct work_struct *work)
 	mutex_unlock(&group->avgs_lock);
 }

-/* Trigger tracking window manupulations */
+/* Trigger tracking window manipulations */
 static void window_reset(struct psi_window *win, u64 now, u64 value,
 			 u64 prev_growth)
 {
--
2.26.2

Re: [PATCH] sched/psi.c: Rudimentary typo fixes

[Johannes Weiner]

On Fri, Mar 26, 2021 at 06:12:33PM +0530, Bhaskar Chowdhury wrote:
> 
> s/possible/possible/
> s/ exceution/execution/
> s/manupulations/manipulations/
> 
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
>  kernel/sched/psi.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
> index 967732c0766c..316ebc57a115 100644
> --- a/kernel/sched/psi.c
> +++ b/kernel/sched/psi.c
> @@ -59,7 +59,7 @@
>   * states, we would have to conclude a CPU SOME pressure number of
>   * 100%, since *somebody* is waiting on a runqueue at all
>   * times. However, that is clearly not the amount of contention the
> - * workload is experiencing: only one out of 256 possible exceution
> + * workload is experiencing: only one out of 256 possible execution

I thought this was the french spelling.

Joking aside, the corrections look right, but I also had no trouble
understanding what those sentences mean. Typos happen, plus we have a
lot of non-native speakers who won't use perfect spelling or grammar.

So for me, the bar is "this can be easily understood", not "needs to
be perfect English", and I'd say let's skip patches like these unless
they fix something truly unintelligble.

Re: [PATCH] sched/psi.c: Rudimentary typo fixes

[Peter Zijlstra]

On Fri, Mar 26, 2021 at 02:00:18PM -0400, Johannes Weiner wrote:
> On Fri, Mar 26, 2021 at 06:12:33PM +0530, Bhaskar Chowdhury wrote:
> > 
> > s/possible/possible/
> > s/ exceution/execution/
> > s/manupulations/manipulations/
> > 
> > Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> > ---
> >  kernel/sched/psi.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
> > index 967732c0766c..316ebc57a115 100644
> > --- a/kernel/sched/psi.c
> > +++ b/kernel/sched/psi.c
> > @@ -59,7 +59,7 @@
> >   * states, we would have to conclude a CPU SOME pressure number of
> >   * 100%, since *somebody* is waiting on a runqueue at all
> >   * times. However, that is clearly not the amount of contention the
> > - * workload is experiencing: only one out of 256 possible exceution
> > + * workload is experiencing: only one out of 256 possible execution
> 
> I thought this was the french spelling.
> 
> Joking aside, the corrections look right, but I also had no trouble
> understanding what those sentences mean. Typos happen, plus we have a
> lot of non-native speakers who won't use perfect spelling or grammar.
> 
> So for me, the bar is "this can be easily understood", not "needs to
> be perfect English", and I'd say let's skip patches like these unless
> they fix something truly unintelligble.

Ignore this robot, lots of people already have a special mail rule for
him. On top of that, this spelling mistake was already fixed by Ingo in:

 3b03706fa621 ("sched: Fix various typos")

Which is part of a series of such patches to head off the endless,
mindless, stream of this.

Re: [PATCH] sched/psi.c: Rudimentary typo fixes

[Bhaskar Chowdhury]

[-- Attachment #1: Type: text/plain, Size: 1503 bytes --]

On 14:00 Fri 26 Mar 2021, Johannes Weiner wrote:
>On Fri, Mar 26, 2021 at 06:12:33PM +0530, Bhaskar Chowdhury wrote:
>>
>> s/possible/possible/
>> s/ exceution/execution/
>> s/manupulations/manipulations/
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> ---
>>  kernel/sched/psi.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
>> index 967732c0766c..316ebc57a115 100644
>> --- a/kernel/sched/psi.c
>> +++ b/kernel/sched/psi.c
>> @@ -59,7 +59,7 @@
>>   * states, we would have to conclude a CPU SOME pressure number of
>>   * 100%, since *somebody* is waiting on a runqueue at all
>>   * times. However, that is clearly not the amount of contention the
>> - * workload is experiencing: only one out of 256 possible exceution
>> + * workload is experiencing: only one out of 256 possible execution
>
>I thought this was the french spelling.
>
>Joking aside, the corrections look right, but I also had no trouble
>understanding what those sentences mean. Typos happen, plus we have a
>lot of non-native speakers who won't use perfect spelling or grammar.
>
>So for me, the bar is "this can be easily understood", not "needs to
>be perfect English", and I'd say let's skip patches like these unless
>they fix something truly unintelligble.
>

OH gosh! For fuck's sake please don't misinterpret. I have had no intension to
pick on others hard work. I was just merely trying to make other work good and
beautiful.



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] sched/psi.c: Rudimentary typo fixes

[Bhaskar Chowdhury]

[-- Attachment #1: Type: text/plain, Size: 2109 bytes --]

On 19:41 Fri 26 Mar 2021, Peter Zijlstra wrote:
>On Fri, Mar 26, 2021 at 02:00:18PM -0400, Johannes Weiner wrote:
>> On Fri, Mar 26, 2021 at 06:12:33PM +0530, Bhaskar Chowdhury wrote:
>> >
>> > s/possible/possible/
>> > s/ exceution/execution/
>> > s/manupulations/manipulations/
>> >
>> > Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> > ---
>> >  kernel/sched/psi.c | 6 +++---
>> >  1 file changed, 3 insertions(+), 3 deletions(-)
>> >
>> > diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
>> > index 967732c0766c..316ebc57a115 100644
>> > --- a/kernel/sched/psi.c
>> > +++ b/kernel/sched/psi.c
>> > @@ -59,7 +59,7 @@
>> >   * states, we would have to conclude a CPU SOME pressure number of
>> >   * 100%, since *somebody* is waiting on a runqueue at all
>> >   * times. However, that is clearly not the amount of contention the
>> > - * workload is experiencing: only one out of 256 possible exceution
>> > + * workload is experiencing: only one out of 256 possible execution
>>
>> I thought this was the french spelling.
>>
>> Joking aside, the corrections look right, but I also had no trouble
>> understanding what those sentences mean. Typos happen, plus we have a
>> lot of non-native speakers who won't use perfect spelling or grammar.
>>
>> So for me, the bar is "this can be easily understood", not "needs to
>> be perfect English", and I'd say let's skip patches like these unless
>> they fix something truly unintelligble.
>
>Ignore this robot, lots of people already have a special mail rule for
>him. On top of that, this spelling mistake was already fixed by Ingo in:
>

Dude, this is a human being and you are suggesting a fucking stupid solution
to others. I know what Ingo did and very appreciable. Please try to be
cooperative and help. Stop spreading FUD ...for fuck's sake ...man..

I am not doing it fun...you need to understand that . ...


..and I have some special rule for some people to ...who the fuck care
...ahhhhhhhhhh
> 3b03706fa621 ("sched: Fix various typos")
>
>Which is part of a series of such patches to head off the endless,
>mindless, stream of this.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] sched/psi.c: Rudimentary typo fixes

[Shuah Khan]

On 3/26/21 1:42 PM, Bhaskar Chowdhury wrote:
> On 19:41 Fri 26 Mar 2021, Peter Zijlstra wrote:
>> On Fri, Mar 26, 2021 at 02:00:18PM -0400, Johannes Weiner wrote:
>>> On Fri, Mar 26, 2021 at 06:12:33PM +0530, Bhaskar Chowdhury wrote:
>>> >
>>> > s/possible/possible/
>>> > s/ exceution/execution/
>>> > s/manupulations/manipulations/
>>> >
>>> > Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>>> > ---
>>> >  kernel/sched/psi.c | 6 +++---
>>> >  1 file changed, 3 insertions(+), 3 deletions(-)
>>> >
>>> > diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
>>> > index 967732c0766c..316ebc57a115 100644
>>> > --- a/kernel/sched/psi.c
>>> > +++ b/kernel/sched/psi.c
>>> > @@ -59,7 +59,7 @@
>>> >   * states, we would have to conclude a CPU SOME pressure number of
>>> >   * 100%, since *somebody* is waiting on a runqueue at all
>>> >   * times. However, that is clearly not the amount of contention the
>>> > - * workload is experiencing: only one out of 256 possible exceution
>>> > + * workload is experiencing: only one out of 256 possible execution
>>>
>>> I thought this was the french spelling.
>>>
>>> Joking aside, the corrections look right, but I also had no trouble
>>> understanding what those sentences mean. Typos happen, plus we have a
>>> lot of non-native speakers who won't use perfect spelling or grammar.
>>>
>>> So for me, the bar is "this can be easily understood", not "needs to
>>> be perfect English", and I'd say let's skip patches like these unless
>>> they fix something truly unintelligble.
>>
>> Ignore this robot, lots of people already have a special mail rule for
>> him. On top of that, this spelling mistake was already fixed by Ingo in:
>>
> 
> Dude, this is a human being and you are suggesting a fucking stupid 
> solution
> to others. I know what Ingo did and very appreciable. Please try to be
> cooperative and help. Stop spreading FUD ...for fuck's sake ...man..
> 
> I am not doing it fun...you need to understand that . ...
> 
> 
> ..and I have some special rule for some people to ...who the fuck care
> ...ahhhhhhhhhh

Bhaskar Chowdhury,

Please be advised that we have received a CoC complaint about your
responses to the following patch discussions:

- https://lore.kernel.org/lkml/YGFrvwX8QngvwPbA@Gentoo/
- https://lore.kernel.org/lkml/YF45Qi+%2FeB+%2Fm7y%2F@Gentoo/
- https://lore.kernel.org/lkml/YF44jiYiAVkuwE0P@Gentoo/
- https://lore.kernel.org/r/YGHOxwiqwhGAs819@Gentoo

There is no requirement that anyone accept your patches. Accepting
feedback and working with the community will ensure that your work
will be taken seriously now and in the future.

Your responses go against the CoC. If this continues, we will take
action to add you to the kernel wide blacklist.

Please refer to:
https://www.kernel.org/doc/html/latest/process/code-of-conduct.html

thanks,
-- Shuah (on behalf of the Code of Conduct Committee)