From: kgunda@codeaurora.org
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Abhijeet Dharmapurikar <adharmap@codeaurora.org>,
Nicholas Troast <ntroast@codeaurora.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH V1 5/5] spmi: pmic-arb: use irq_chip callback to set spmi irq wakeup capability
Date: Thu, 06 Jul 2017 16:00:22 +0530 [thread overview]
Message-ID: <1f9393918c769877d28754036596fac1@codeaurora.org> (raw)
In-Reply-To: <20170706064646.GZ22780@codeaurora.org>
On 2017-07-06 12:16, Stephen Boyd wrote:
> On 07/03, Kiran Gunda wrote:
>> diff --git a/drivers/spmi/spmi-pmic-arb.c
>> b/drivers/spmi/spmi-pmic-arb.c
>> index 5285245..2d2e39c 100644
>> --- a/drivers/spmi/spmi-pmic-arb.c
>> +++ b/drivers/spmi/spmi-pmic-arb.c
>> @@ -621,6 +621,19 @@ static int qpnpint_irq_set_type(struct irq_data
>> *d, unsigned int flow_type)
>> return 0;
>> }
>>
>> +static int qpnpint_irq_set_wake(struct irq_data *d, unsigned int on)
>> +{
>> + struct spmi_pmic_arb *pmic_arb = irq_data_get_irq_chip_data(d);
>> + int ret;
>> +
>> + if (on)
>> + ret = enable_irq_wake(pmic_arb->irq);
>> + else
>> + ret = disable_irq_wake(pmic_arb->irq);
>
> Could be simplified to
>
> return irq_set_irq_wake(pmic_arb->irq, on);
>
> ?
>
yes. Will modify it.
>> +
>> + return ret;
>> +}
>> +
>> static int qpnpint_get_irqchip_state(struct irq_data *d,
>> enum irqchip_irq_state which,
>> bool *state)
prev parent reply other threads:[~2017-07-06 10:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-03 12:18 [PATCH V1 0/5]: Fix-up patches Kiran Gunda
2017-07-03 12:18 ` [PATCH V1 1/5] spmi: pmic-arb: remove the read/write access checks Kiran Gunda
2017-07-06 6:48 ` Stephen Boyd
2017-07-03 12:18 ` [PATCH V1 2/5] spmi: pmic-arb: rename pa_xx to pmic_arb_xx and other code cleanup Kiran Gunda
2017-07-06 6:49 ` Stephen Boyd
2017-07-07 14:48 ` kgunda
2017-07-03 12:18 ` [PATCH V1 3/5] spmi: pmic-arb: replace the writel_relaxed with __raw_writel Kiran Gunda
2017-07-06 6:44 ` Stephen Boyd
2017-07-03 12:18 ` [PATCH V1 4/5] spmi: pmic-arb: return the value instead of passing by pointer Kiran Gunda
2017-07-06 6:44 ` Stephen Boyd
2017-07-03 12:18 ` [PATCH V1 5/5] spmi: pmic-arb: use irq_chip callback to set spmi irq wakeup capability Kiran Gunda
2017-07-06 6:46 ` Stephen Boyd
2017-07-06 10:30 ` kgunda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f9393918c769877d28754036596fac1@codeaurora.org \
--to=kgunda@codeaurora.org \
--cc=adharmap@codeaurora.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ntroast@codeaurora.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).