From: Waiman Long <longman@redhat.com>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Shaokun Zhang <zhangshaokun@hisilicon.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Petr Mladek <pmladek@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ben Dooks <ben.dooks@sifive.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Luis Chamberlain <mcgrof@kernel.org>,
Xiaoming Ni <nixiaoming@huawei.com>,
John Ogness <john.ogness@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] locking/lockdep: add debug_show_all_lock_holders()
Date: Fri, 16 Sep 2022 14:41:11 -0400 [thread overview]
Message-ID: <1fd381e0-03e7-df2a-4865-d157714ce9b2@redhat.com> (raw)
In-Reply-To: <9f42e8a5-f809-3f2c-0fda-b7657bc94eb3@I-love.SAKURA.ne.jp>
On 9/16/22 11:57, Tetsuo Handa wrote:
> Currently, check_hung_uninterruptible_tasks() reports details of locks
> held in the system. Also, lockdep_print_held_locks() does not report
> details of locks held by a thread if that thread is in TASK_RUNNING state.
> Several years of experience of debugging without vmcore tells me that
> these limitations have been a barrier for understanding what went wrong
> in syzbot's "INFO: task hung in" reports.
>
> I initially thought that the cause of "INFO: task hung in" reports is
> due to over-stressing. But I understood that over-stressing is unlikely.
> I now consider that there likely is a deadlock/livelock bug where lockdep
> cannot report as a deadlock when "INFO: task hung in" is reported.
>
> A typical case is that thread-1 is waiting for something to happen (e.g.
> wait_event_*()) with a lock held. When thread-2 tries to hold that lock
> using e.g. mutex_lock(), check_hung_uninterruptible_tasks() reports that
> thread-2 is hung and thread-1 is holding a lock which thread-2 is trying
> to hold. But currently check_hung_uninterruptible_tasks() cannot report
> the exact location of thread-1 which gives us an important hint for
> understanding why thread-1 is holding that lock for so long period.
>
> When check_hung_uninterruptible_tasks() reports a thread waiting for a
> lock, it is important to report backtrace of threads which already held
> that lock. Therefore, allow check_hung_uninterruptible_tasks() to report
> the exact location of threads which is holding any lock.
>
> To deduplicate code, share debug_show_all_{locks,lock_holders}() using
> a flag. As a side effect of sharing, __debug_show_all_locks() skips
> current thread if the caller is holding no lock, for reporting RCU lock
> taken inside __debug_show_all_locks() is generally useless.
>
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> ---
> Changes in v2:
> Share debug_show_all_lock_holders() and debug_show_all_locks(),
> suggested by Waiman Long <longman@redhat.com>.
>
> include/linux/debug_locks.h | 17 ++++++++++++++++-
> kernel/hung_task.c | 2 +-
> kernel/locking/lockdep.c | 14 +++++++++++---
> 3 files changed, 28 insertions(+), 5 deletions(-)
>
> diff --git a/include/linux/debug_locks.h b/include/linux/debug_locks.h
> index dbb409d77d4f..b45c89fadfe4 100644
> --- a/include/linux/debug_locks.h
> +++ b/include/linux/debug_locks.h
> @@ -48,7 +48,18 @@ extern int debug_locks_off(void);
> #endif
>
> #ifdef CONFIG_LOCKDEP
> -extern void debug_show_all_locks(void);
> +extern void __debug_show_all_locks(bool show_stack);
> +
> +static inline void debug_show_all_locks(void)
> +{
> + __debug_show_all_locks(false);
> +}
> +
> +static inline void debug_show_all_lock_holders(void)
> +{
> + __debug_show_all_locks(true);
> +}
> +
> extern void debug_show_held_locks(struct task_struct *task);
> extern void debug_check_no_locks_freed(const void *from, unsigned long len);
> extern void debug_check_no_locks_held(void);
> @@ -61,6 +72,10 @@ static inline void debug_show_held_locks(struct task_struct *task)
> {
> }
>
> +static inline void debug_show_all_lock_holders(void)
> +{
> +}
> +
> static inline void
> debug_check_no_locks_freed(const void *from, unsigned long len)
> {
> diff --git a/kernel/hung_task.c b/kernel/hung_task.c
> index bb2354f73ded..18e22bbb714f 100644
> --- a/kernel/hung_task.c
> +++ b/kernel/hung_task.c
> @@ -205,7 +205,7 @@ static void check_hung_uninterruptible_tasks(unsigned long timeout)
> unlock:
> rcu_read_unlock();
> if (hung_task_show_lock)
> - debug_show_all_locks();
> + debug_show_all_lock_holders();
>
> if (hung_task_show_all_bt) {
> hung_task_show_all_bt = false;
> diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
> index 64a13eb56078..7870f7e5c46b 100644
> --- a/kernel/locking/lockdep.c
> +++ b/kernel/locking/lockdep.c
> @@ -55,6 +55,7 @@
> #include <linux/rcupdate.h>
> #include <linux/kprobes.h>
> #include <linux/lockdep.h>
> +#include <linux/sched/debug.h>
>
> #include <asm/sections.h>
>
> @@ -6485,7 +6486,7 @@ void debug_check_no_locks_held(void)
> EXPORT_SYMBOL_GPL(debug_check_no_locks_held);
>
> #ifdef __KERNEL__
> -void debug_show_all_locks(void)
> +void __debug_show_all_locks(bool show_stack)
> {
> struct task_struct *g, *p;
>
> @@ -6493,12 +6494,19 @@ void debug_show_all_locks(void)
> pr_warn("INFO: lockdep is turned off.\n");
> return;
> }
> - pr_warn("\nShowing all locks held in the system:\n");
> + if (show_stack)
> + pr_warn("\nShowing all threads with locks held in the system:\n");
> + else
> + pr_warn("\nShowing all locks held in the system:\n");
>
> rcu_read_lock();
> for_each_process_thread(g, p) {
> if (!p->lockdep_depth)
> continue;
> + if (p == current && p->lockdep_depth == 1)
> + continue;
> + if (show_stack)
> + sched_show_task(p);
> lockdep_print_held_locks(p);
> touch_nmi_watchdog();
> touch_all_softlockup_watchdogs();
> @@ -6508,7 +6516,7 @@ void debug_show_all_locks(void)
> pr_warn("\n");
> pr_warn("=============================================\n\n");
> }
> -EXPORT_SYMBOL_GPL(debug_show_all_locks);
> +EXPORT_SYMBOL_GPL(__debug_show_all_locks);
> #endif
>
> /*
Acked-by: Waiman Long <longman@redhat.com>
next prev parent reply other threads:[~2022-09-16 18:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 14:15 [PATCH (repost)] locking/lockdep: add debug_show_all_lock_holders() Tetsuo Handa
2022-09-16 14:51 ` Waiman Long
2022-09-16 15:57 ` [PATCH v2] " Tetsuo Handa
2022-09-16 18:41 ` Waiman Long [this message]
2022-10-03 22:18 ` Tetsuo Handa
2022-10-04 18:09 ` Waiman Long
2022-11-14 10:05 ` Tetsuo Handa
2022-09-16 17:46 ` [PATCH (repost)] " Boqun Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fd381e0-03e7-df2a-4865-d157714ce9b2@redhat.com \
--to=longman@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ben.dooks@sifive.com \
--cc=bigeasy@linutronix.de \
--cc=boqun.feng@gmail.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mcgrof@kernel.org \
--cc=mingo@redhat.com \
--cc=nixiaoming@huawei.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).