From: Boqun Feng <boqun.feng@gmail.com>
To: Waiman Long <longman@redhat.com>
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Shaokun Zhang <zhangshaokun@hisilicon.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Petr Mladek <pmladek@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ben Dooks <ben.dooks@sifive.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Luis Chamberlain <mcgrof@kernel.org>,
Xiaoming Ni <nixiaoming@huawei.com>,
John Ogness <john.ogness@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH (repost)] locking/lockdep: add debug_show_all_lock_holders()
Date: Fri, 16 Sep 2022 10:46:18 -0700 [thread overview]
Message-ID: <YyS2aoPoC2TznZHO@boqun-archlinux> (raw)
In-Reply-To: <3e027453-fda4-3891-3ec3-5623f1525e56@redhat.com>
On Fri, Sep 16, 2022 at 10:51:14AM -0400, Waiman Long wrote:
[...]
> >
> > I'm expecting lockdep to continue working without calling printk() even after
> > one of problem patterns (e.g. circular locking dependency) was printk()ed, so that
> > debug_show_all_locks()/debug_show_all_lock_holders() can call printk() when needed.
> >
> > Changing debug_locks behavior is a future patch. For now, this patch alone
> > will help debugging Greg's usb.git#usb-testing tree which is generating
> > many "INFO: task hung in" reports.
The default behavior today does make sense: if the system has one
deadlock it should be fixed first before searching out another. So I
expect that changing debug_locks behavior would be configurable and we
keep the default as today.
>
> Boqun is actually working on a modularization patch to make some lockdep
> checking still active even after a lockdep bug is reported. I think he will
> take into consideration about this request.
>
Yes, this is one of the "problems" I try to resolve while cleaning up
the lockdep.
Regards,
Boqun
> Cheers,
> Longman
>
prev parent reply other threads:[~2022-09-16 17:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 14:15 [PATCH (repost)] locking/lockdep: add debug_show_all_lock_holders() Tetsuo Handa
2022-09-16 14:51 ` Waiman Long
2022-09-16 15:57 ` [PATCH v2] " Tetsuo Handa
2022-09-16 18:41 ` Waiman Long
2022-10-03 22:18 ` Tetsuo Handa
2022-10-04 18:09 ` Waiman Long
2022-11-14 10:05 ` Tetsuo Handa
2022-09-16 17:46 ` Boqun Feng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyS2aoPoC2TznZHO@boqun-archlinux \
--to=boqun.feng@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ben.dooks@sifive.com \
--cc=bigeasy@linutronix.de \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=longman@redhat.com \
--cc=mcgrof@kernel.org \
--cc=mingo@redhat.com \
--cc=nixiaoming@huawei.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).