[GIT PULL] KGDB/KDB fixes for 4.15-rc2

[GIT PULL] KGDB/KDB fixes for 4.15-rc2

[Jason Wessel]

Linus,

Please pull the kgdb tree.

Summary of changes:
   * Fix long standing problem with kdb kallsyms_symbol_next() return value
   * Add new co-maintainer Daniel Thompson

git://git.kernel.org/pub/scm/linux/kernel/git/jwessel/kgdb.git tags/for_linus-4.15-rc2

Thanks,
Jason.

The following changes since commit bebc6082da0a9f5d47a1ea2edc099bf671058bd4:

  Linux 4.14 (2017-11-12 10:46:13 -0800)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/jwessel/kgdb.git tags/for_linus-4.15-rc2

for you to fetch changes up to 4e23f78c74934e8ea624b59df58e646e0657608a:

  kgdb/kdb/debug_core: Add co-maintainer Daniel Thompson (2017-12-06 16:12:43 -0600)

----------------------------------------------------------------
KGDB:
   * Fix long standing problem with kdb kallsyms_symbol_next() return value
   * Add new co-maintainer Daniel Thompson

----------------------------------------------------------------
Daniel Thompson (1):
      kdb: Fix handling of kallsyms_symbol_next() return value

Jason Wessel (1):
      kgdb/kdb/debug_core: Add co-maintainer Daniel Thompson

 MAINTAINERS               | 1 +
 kernel/debug/kdb/kdb_io.c | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

[PATCH 1/2] kdb: Fix handling of kallsyms_symbol_next() return value

[Jason Wessel]

From: Daniel Thompson <daniel.thompson@linaro.org>

kallsyms_symbol_next() returns a boolean (true on success). Currently
kdb_read() tests the return value with an inequality that
unconditionally evaluates to true.

This is fixed in the obvious way and, since the conditional branch is
supposed to be unreachable, we also add a WARN_ON().

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
---
 kernel/debug/kdb/kdb_io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c
index e74be38..ed5d349 100644
--- a/kernel/debug/kdb/kdb_io.c
+++ b/kernel/debug/kdb/kdb_io.c
@@ -350,7 +350,7 @@ static char *kdb_read(char *buffer, size_t bufsize)
 			}
 			kdb_printf("\n");
 			for (i = 0; i < count; i++) {
-				if (kallsyms_symbol_next(p_tmp, i) < 0)
+				if (WARN_ON(!kallsyms_symbol_next(p_tmp, i)))
 					break;
 				kdb_printf("%s ", p_tmp);
 				*(p_tmp + len) = '\0';
-- 
1.9.1

[PATCH 2/2] kgdb/kdb/debug_core: Add co-maintainer Daniel Thompson

[Jason Wessel]

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 2811a21..74be63b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7659,6 +7659,7 @@ F:	security/keys/
 
 KGDB / KDB /debug_core
 M:	Jason Wessel <jason.wessel@windriver.com>
+M:	Daniel Thompson <daniel.thompson@linaro.org>
 W:	http://kgdb.wiki.kernel.org/
 L:	kgdb-bugreport@lists.sourceforge.net
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/jwessel/kgdb.git
-- 
1.9.1

Re: [PATCH 2/2] kgdb/kdb/debug_core: Add co-maintainer Daniel Thompson

[Randy Dunlap]

On 12/06/2017 02:33 PM, Jason Wessel wrote:
> Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2811a21..74be63b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7659,6 +7659,7 @@ F:	security/keys/
>  
>  KGDB / KDB /debug_core
>  M:	Jason Wessel <jason.wessel@windriver.com>
> +M:	Daniel Thompson <daniel.thompson@linaro.org>
>  W:	http://kgdb.wiki.kernel.org/
>  L:	kgdb-bugreport@lists.sourceforge.net
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/jwessel/kgdb.git
> 

I would urge you to move to a different mailing list server.

> grep -c lists.sourceforge.net MAINTAINERS
42
> grep -c vger.kernel.org MAINTAINERS
1120
> grep -c lists.infradead.org MAINTAINERS
193



-- 
~Randy

Re: [PATCH 2/2] kgdb/kdb/debug_core: Add co-maintainer Daniel Thompson

[Jason Wessel]

On 12/06/2017 06:52 PM, Randy Dunlap wrote:
> On 12/06/2017 02:33 PM, Jason Wessel wrote:
>>   L:	kgdb-bugreport@lists.sourceforge.net
>>   T:	git git://git.kernel.org/pub/scm/linux/kernel/git/jwessel/kgdb.git
>>
> 
> I would urge you to move to a different mailing list server.

No argument here, considering some of the past problems with the mail list.  I put in a request to get a list created on vger, and it can be migrated after it gets created.

Thanks,
Jason.