* [PATCH net v1] Revert "net: phy: dp83867: perform soft reset and retain established link"
@ 2023-06-19 15:44 Francesco Dolcini
2023-06-19 16:30 ` Andrew Lunn
2023-06-21 3:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: Francesco Dolcini @ 2023-06-19 15:44 UTC (permalink / raw)
To: Andrew Lunn, Heiner Kallweit, Russell King, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, linux-kernel
Cc: Francesco Dolcini, Geet Modi, Praneeth Bajjuri, netdev
From: Francesco Dolcini <francesco.dolcini@toradex.com>
This reverts commit da9ef50f545f86ffe6ff786174d26500c4db737a.
This fixes a regression in which the link would come up, but no
communication was possible.
The reverted commit was also removing a comment about
DP83867_PHYCR_FORCE_LINK_GOOD, this is not added back in this commits
since it seems that this is unrelated to the original code change.
Cc: Praneeth Bajjuri <praneeth@ti.com>
Closes: https://lore.kernel.org/all/ZGuDJos8D7N0J6Z2@francesco-nb.int.toradex.com/
Fixes: da9ef50f545f ("net: phy: dp83867: perform soft reset and retain established link")
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
drivers/net/phy/dp83867.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
index 76f5a2402fb0..e397e7d642d9 100644
--- a/drivers/net/phy/dp83867.c
+++ b/drivers/net/phy/dp83867.c
@@ -936,7 +936,7 @@ static int dp83867_phy_reset(struct phy_device *phydev)
{
int err;
- err = phy_write(phydev, DP83867_CTRL, DP83867_SW_RESTART);
+ err = phy_write(phydev, DP83867_CTRL, DP83867_SW_RESET);
if (err < 0)
return err;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net v1] Revert "net: phy: dp83867: perform soft reset and retain established link"
2023-06-19 15:44 [PATCH net v1] Revert "net: phy: dp83867: perform soft reset and retain established link" Francesco Dolcini
@ 2023-06-19 16:30 ` Andrew Lunn
2023-06-19 19:49 ` Bajjuri, Praneeth
2023-06-21 3:40 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 4+ messages in thread
From: Andrew Lunn @ 2023-06-19 16:30 UTC (permalink / raw)
To: Francesco Dolcini
Cc: Heiner Kallweit, Russell King, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, linux-kernel, Francesco Dolcini,
Geet Modi, Praneeth Bajjuri, netdev
On Mon, Jun 19, 2023 at 05:44:35PM +0200, Francesco Dolcini wrote:
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
>
> This reverts commit da9ef50f545f86ffe6ff786174d26500c4db737a.
>
> This fixes a regression in which the link would come up, but no
> communication was possible.
>
> The reverted commit was also removing a comment about
> DP83867_PHYCR_FORCE_LINK_GOOD, this is not added back in this commits
> since it seems that this is unrelated to the original code change.
>
> Cc: Praneeth Bajjuri <praneeth@ti.com>
> Closes: https://lore.kernel.org/all/ZGuDJos8D7N0J6Z2@francesco-nb.int.toradex.com/
> Fixes: da9ef50f545f ("net: phy: dp83867: perform soft reset and retain established link")
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
There has been plenty of time given for somebody to investigate this
regression, and nothing has happened. So i agree, lets revert it.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net v1] Revert "net: phy: dp83867: perform soft reset and retain established link"
2023-06-19 16:30 ` Andrew Lunn
@ 2023-06-19 19:49 ` Bajjuri, Praneeth
0 siblings, 0 replies; 4+ messages in thread
From: Bajjuri, Praneeth @ 2023-06-19 19:49 UTC (permalink / raw)
To: Andrew Lunn, Francesco Dolcini, Siddharth Vadapalli
Cc: Heiner Kallweit, Russell King, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, linux-kernel, Francesco Dolcini,
Geet Modi, netdev
On 6/19/2023 11:30 AM, Andrew Lunn wrote:
> On Mon, Jun 19, 2023 at 05:44:35PM +0200, Francesco Dolcini wrote:
>> From: Francesco Dolcini <francesco.dolcini@toradex.com>
>>
>> This reverts commit da9ef50f545f86ffe6ff786174d26500c4db737a.
>>
>> This fixes a regression in which the link would come up, but no
>> communication was possible.
>>
>> The reverted commit was also removing a comment about
>> DP83867_PHYCR_FORCE_LINK_GOOD, this is not added back in this commits
>> since it seems that this is unrelated to the original code change.
>>
>> Cc: Praneeth Bajjuri <praneeth@ti.com>
>> Closes: https://lore.kernel.org/all/ZGuDJos8D7N0J6Z2@francesco-nb.int.toradex.com/
>> Fixes: da9ef50f545f ("net: phy: dp83867: perform soft reset and retain established link")
>> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
>
> There has been plenty of time given for somebody to investigate this
> regression, and nothing has happened. So i agree, lets revert it.
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Agreed to revert.
Reviewed-by: Praneeth Bajjuri <praneeth@ti.com>
>
> Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net v1] Revert "net: phy: dp83867: perform soft reset and retain established link"
2023-06-19 15:44 [PATCH net v1] Revert "net: phy: dp83867: perform soft reset and retain established link" Francesco Dolcini
2023-06-19 16:30 ` Andrew Lunn
@ 2023-06-21 3:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-06-21 3:40 UTC (permalink / raw)
To: Francesco Dolcini
Cc: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni,
linux-kernel, francesco.dolcini, geet.modi, praneeth, netdev
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 19 Jun 2023 17:44:35 +0200 you wrote:
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
>
> This reverts commit da9ef50f545f86ffe6ff786174d26500c4db737a.
>
> This fixes a regression in which the link would come up, but no
> communication was possible.
>
> [...]
Here is the summary with links:
- [net,v1] Revert "net: phy: dp83867: perform soft reset and retain established link"
https://git.kernel.org/netdev/net/c/a129b41fe0a8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-21 3:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-19 15:44 [PATCH net v1] Revert "net: phy: dp83867: perform soft reset and retain established link" Francesco Dolcini
2023-06-19 16:30 ` Andrew Lunn
2023-06-19 19:49 ` Bajjuri, Praneeth
2023-06-21 3:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).