From: Jean Tourrilhes <jt@spica.hpl.hp.com>
To: Dag Brattli <dagb@fast.no>
Cc: torvalds@transmeta.com, alan@lxorguk.ukuu.org.uk,
jgarzik@mandrakesoft.com, linux-kernel@vger.rutgers.edu
Subject: Re: [RANT] Linux-IrDA status
Date: Wed, 8 Nov 2000 10:20:42 -0800 [thread overview]
Message-ID: <20001108102042.A24811@bougret.hpl.hp.com> (raw)
In-Reply-To: <Pine.LNX.4.10.10011072027520.15254-100000@penguin.transmeta.com> <200011081204.MAA68767@tepid.osl.fast.no>
In-Reply-To: <200011081204.MAA68767@tepid.osl.fast.no>; from dagb@fast.no on Wed, Nov 08, 2000 at 12:04:05PM +0000
On Wed, Nov 08, 2000 at 12:04:05PM +0000, Dag Brattli wrote:
>
> Hi,
>
> It was implemented this way because the IrDA device drivers are implemented
> like normal network device drivers and didn't want to mess with struct netdevice
> in order to change the speed of the driver. I decided to use ioctl since it had to
> be possible to do this from user-space (sniffers) as well as from the IrDA stack.
> The only thing the IrDA stack knows about is the netdevice. Some frames we
> receive will trigger a speed change which we must handle from within the
> stack (so it's inside the bh and not actually in the "hard" interrupt)
>
> What do you suggest I do?
>
> 1. Add a change_speed() function to struct netdevice
> 2. Add a protocol specific pointer to struct netdevice
> 3. Embed the speed in skb->cb and send down empty frames
> when I want to change the speed without transmitting anything.
> 4. Anything else?
If somebody tell us which is the "right way", I'll try to code
that ASAP. We take any feedback very seriously ;-)
I personally would go with #1, because "struct netdevice" is
full of protocol specific stuff anyway... And if we do our job right,
it can be reused for other stuff.
Any comments ?
> -- Dag
Jean
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next parent reply other threads:[~2000-11-08 18:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.10.10011072027520.15254-100000@penguin.transmeta.com>
[not found] ` <200011081204.MAA68767@tepid.osl.fast.no>
2000-11-08 18:20 ` Jean Tourrilhes [this message]
[not found] <Pine.LNX.4.10.10011072030070.15254-100000@penguin.transmeta.com>
2000-11-08 5:08 ` [RANT] Linux-IrDA status Michael Rothwell
2000-11-08 5:23 ` Linus Torvalds
2000-11-08 7:26 ` Linus Torvalds
2000-11-08 8:14 ` Russell King
2000-11-08 12:15 ` [RANT] Linux-IrDA status, " Dag Brattli
2000-11-10 21:24 ` Pavel Machek
2000-11-08 12:31 ` Michael Rothwell
2000-11-08 1:14 Jean Tourrilhes
[not found] ` <3A08AB56.10BD5007@mandrakesoft.com>
2000-11-08 1:38 ` Jean Tourrilhes
2000-11-08 8:12 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20001108102042.A24811@bougret.hpl.hp.com \
--to=jt@spica.hpl.hp.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dagb@fast.no \
--cc=jgarzik@mandrakesoft.com \
--cc=jt@hpl.hp.com \
--cc=linux-kernel@vger.rutgers.edu \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).