linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: Linux 2.2.18pre21
  2000-11-10  3:07 ` Alan Cox
@ 2000-11-10 10:59 Arnaud S . Launay
  2000-11-10  3:07 ` Alan Cox
  2 siblings, 1 reply; 40+ messages in thread
From: Arnaud S . Launay @ 2000-11-10 10:59 UTC (permalink / raw)
  To: Alan Cox; +Cc: linux-kernel

[-- Attachment #1: Type: text/plain, Size: 349 bytes --]

Le Fri, Nov 10, 2000 at 03:07:21AM +0000, Alan Cox a écrit:
> Anything which isnt a strict bug fix or previously agreed is now 2.2.19
> material.

Compiling 2.2.18pre21 without sysctl gives an error at linkage:
kernel/kernel.o(__ksymtab+0x608): undefined reference to `sysctl_jiffies'

trivial patch included, not sure it's the right one.

	Arnaud.

[-- Attachment #2: diff-ksyms --]
[-- Type: text/plain, Size: 358 bytes --]

--- linux/kernel/ksyms.old	Fri Nov 10 11:58:20 2000
+++ linux/kernel/ksyms.c	Fri Nov 10 11:58:24 2000
@@ -284,7 +284,6 @@
 EXPORT_SYMBOL(register_sysctl_table);
 EXPORT_SYMBOL(unregister_sysctl_table);
 EXPORT_SYMBOL(sysctl_string);
-EXPORT_SYMBOL(sysctl_jiffies);
 EXPORT_SYMBOL(sysctl_intvec);
 EXPORT_SYMBOL(proc_dostring);
 EXPORT_SYMBOL(proc_dointvec);

^ permalink raw reply	[flat|nested] 40+ messages in thread
* Re: Linux 2.2.18pre21
@ 2000-11-13  9:47 willy tarreau
  0 siblings, 0 replies; 40+ messages in thread
From: willy tarreau @ 2000-11-13  9:47 UTC (permalink / raw)
  To: Matti Aarnio, Constantine Gavrilov; +Cc: willy tarreau, alan, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 294 bytes --]

Oops !
better with the patch :-)

Willy

> Ok, Matti,
> here's a final patch against the bonding patch I
> posted on Friday.


___________________________________________________________
Do You Yahoo!? -- Pour dialoguer en direct avec vos amis, 
Yahoo! Messenger : http://fr.messenger.yahoo.com

[-- Attachment #2: patch-etherchannel-fix.gz --]
[-- Type: application/x-unknown, Size: 1357 bytes --]

^ permalink raw reply	[flat|nested] 40+ messages in thread
* Re: Linux 2.2.18pre21
@ 2000-11-13  7:00 willy tarreau
  0 siblings, 0 replies; 40+ messages in thread
From: willy tarreau @ 2000-11-13  7:00 UTC (permalink / raw)
  To: Matti Aarnio, Constantine Gavrilov; +Cc: willy tarreau, alan, linux-kernel

Ok, Matti,
here's a final patch against the bonding patch I
posted
on Friday. Could you tell me if it fits your needs ?
If so, I would repost (offline) the complete one
against 2.2.18pre21. Anyway, for those curious here,
it's available at the following URL:

http://www-miaif.lip6.fr/willy/pub/linux-patches/bonding/patch-2.2.18p21-bonding-20001113.gz

Regards,
Willy


___________________________________________________________
Do You Yahoo!? -- Pour dialoguer en direct avec vos amis, 
Yahoo! Messenger : http://fr.messenger.yahoo.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 40+ messages in thread
* Re: Linux 2.2.18pre21
@ 2000-11-10 11:21 willy tarreau
  0 siblings, 0 replies; 40+ messages in thread
From: willy tarreau @ 2000-11-10 11:21 UTC (permalink / raw)
  To: Matti Aarnio, Constantine Gavrilov; +Cc: willy tarreau, alan, linux-kernel

> I don't like to call it BONDING.
> "Bonding" is something where two (or more) channels
> carry data in between two participating systems.
> Like Multilink-PPP, and ISDN Channel Bonding.  Often
> indeed data goes out somehow inter-leaved on the
> physical links.  (Like ISDN Channel Bonding supplies
> a transparent 128 kbps link instead of two 64
> kbps links to the upper layers.)

this is *EXACTLY* what the old bonding driver does,
and what the new one does by default.

> EtherChannel does select the link (out of the group)
> by forming XOR of source and destination MAC
> addresses (their lowest bytes),
.../...
> This gives improved throughput on congested links
> in between two switches, or major server and core
> switches, while preserving data order over the
links.

OK, I've read about it because Thomas Davis asked me
if I would implement it. I didn't find it usefull for
the case of a Linux server directly connected to a
router or a level X switch (x>2) because in this case
only one link is getting used. Perhaps I'm wrong, but
I think this is the major use of the current Linux
bonding driver. However, the new driver is now ready
for such an implementation.

> Blind bonding-type "throw packets on links 0 and 1"
> MAY end up sending ethernet frames out of sequence,
> which for a few LAN based protocols is a great
source
> of upset.
probably, but do you have examples in mind ? if so, I
would add XOR to a next release, but I don't want to
add too much at a time. I consider this release
primarily as a bugfix (smp, security, oopses...), and
as an improvement which now supports link fail-over,
which is also a primary concern when implementing
multilinks.

> Beowulf systems have "bonding" in use for parallel
> Ethernet links in between two machines, however THAT
> is not EtherChannel compatible thing!

yes it is compatible ! compatible doesn't mean it does
not work the same way, but it works with. Both the
cisco and linux drivers agree to receive on each of
their trunk ports, so the difference only resides in
link optimization when sending frames.

> /Matti Aarnio

Willy


___________________________________________________________
Do You Yahoo!? -- Pour dialoguer en direct avec vos amis, 
Yahoo! Messenger : http://fr.messenger.yahoo.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 40+ messages in thread
* Re: Linux 2.2.18pre21
@ 2000-11-10 10:49 willy tarreau
  0 siblings, 0 replies; 40+ messages in thread
From: willy tarreau @ 2000-11-10 10:49 UTC (permalink / raw)
  To: Matti Aarnio; +Cc: alan, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 632 bytes --]

> > >         is important.  We could call it
ETHERNETCHANNEL (and even
> > >         "Etherchannel" or "ETHERCHANNEL") get
away with it clean.
> > > ...
> > > /Matti Aarnio
 
> 	Anything but "EtherChannel" -- trademark people 


Ok, Matti. Let's keep "Etherchannel" as you proposed
and as it was documented in the Configure.help. This
patch fixes it (I won't resend the complete patch
on the LKML because 20kB is generally to big for
unconcerned people).

Willy


___________________________________________________________
Do You Yahoo!? -- Pour dialoguer en direct avec vos amis, 
Yahoo! Messenger : http://fr.messenger.yahoo.com

[-- Attachment #2: etherchannel-spelling-fix.diff.gz --]
[-- Type: application/x-unknown, Size: 944 bytes --]

^ permalink raw reply	[flat|nested] 40+ messages in thread
* Re: Linux 2.2.18pre21
@ 2000-11-10 10:40 willy tarreau
  0 siblings, 0 replies; 40+ messages in thread
From: willy tarreau @ 2000-11-10 10:40 UTC (permalink / raw)
  To: Constantine Gavrilov; +Cc: alan, linux-kernel

> However, it has not been tested enough that I may
bet
> by head on saying there are no known issues.

I won't say there are no issues, but I'd say there are
no KNOWN issues.

> This is because I did not have access to all
> hardware that was needed to complete the tests in
> time.

I know that, Constantine. But I know a few people at
work who used it (me included), and I also had a
report
from a guy in germany using it with success.
I know this is really not much, but we used to read
about problems by the past, and I haven't received
even one complaint about the new one, so I bet it's a
bit better than it was.

> The code is not worse than the old code. However, a
> clear note must be made that this is experimental
> code and probably has small issues.

as always, and just like any other driver (eg: I'll
try
to take some time to make the megaraid work again on
my server).

> So if it is included, it must me marked as
experimental.

agreed.


Regards,
Willy


___________________________________________________________
Do You Yahoo!? -- Pour dialoguer en direct avec vos amis, 
Yahoo! Messenger : http://fr.messenger.yahoo.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 40+ messages in thread
* Re: Linux 2.2.18pre21
@ 2000-11-10  9:28 willy tarreau
  2000-11-10  9:44 ` Matti Aarnio
  2000-11-10 10:18 ` Constantine Gavrilov
  0 siblings, 2 replies; 40+ messages in thread
From: willy tarreau @ 2000-11-10  9:28 UTC (permalink / raw)
  To: alan; +Cc: linux-kernel, const-g

[-- Attachment #1: Type: text/plain, Size: 728 bytes --]

> Anything which isnt a strict bug fix or previously
> agreed is now 2.2.19 material.

Alan, do you consider it as a bugfix if I tell you
that
we can't get anymore oops with the new bonding code,
even in SMP ?

I've had reports of it working very well, and faster,
for a long time now and the link detection seems
completely OK now. I'd like to specially thank
Constantine Gavrilov for all the tests he has done and
the time he spent in enhancing the documentation.

Please find the patch against 2.2.18pre20 in
attachment, in case you agree.

Regards,
Willy


___________________________________________________________
Do You Yahoo!? -- Pour dialoguer en direct avec vos amis, 
Yahoo! Messenger : http://fr.messenger.yahoo.com

[-- Attachment #2: patch-bonding-2.2.18p20-20001101.gz --]
[-- Type: application/x-unknown, Size: 20653 bytes --]

^ permalink raw reply	[flat|nested] 40+ messages in thread

end of thread, other threads:[~2000-11-21  4:51 UTC | newest]

Thread overview: 40+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2000-11-10 10:59 Linux 2.2.18pre21 Arnaud S . Launay
2000-11-10  3:07 ` Alan Cox
2000-11-10  3:44   ` David S. Miller
2000-11-10 11:35     ` Benjamin Herrenschmidt
2000-11-10 15:34       ` David S. Miller
2000-11-10 15:42       ` Tom Rini
2000-11-10 10:52   ` David S. Miller
2000-11-16 14:07   ` Matthias Andree
2000-11-16 16:16     ` Andrea Arcangeli
2000-11-16 19:52       ` jesse
2000-11-16 20:02         ` chroot [Was: Re: Linux 2.2.18pre21] Kurt Roeckx
2000-11-16 21:40         ` Linux 2.2.18pre21 Alan Cox
2000-11-18 10:07           ` Rogier Wolff
2000-11-18 17:32             ` kuznet
2000-11-18 17:34               ` Rogier Wolff
2000-11-18 17:47                 ` kuznet
2000-11-18 17:51                   ` Rogier Wolff
2000-11-16 22:56         ` Matthias Andree
2000-11-17  6:30         ` Peter Samuelson
2000-11-17  6:40           ` H. Peter Anvin
2000-11-17 11:22             ` Peter Samuelson
2000-11-17 17:35               ` H. Peter Anvin
2000-11-17 11:34             ` Matthias Andree
2000-11-17 19:23           ` jesse
2000-11-18 20:44             ` Pavel Machek
2000-11-18  1:38           ` Nix
2000-11-21  4:19             ` Peter Samuelson
  -- strict thread matches above, loose matches on Subject: below --
2000-11-13  9:47 willy tarreau
2000-11-13  7:00 willy tarreau
2000-11-10 11:21 willy tarreau
2000-11-10 10:49 willy tarreau
2000-11-10 10:40 willy tarreau
2000-11-10  9:28 willy tarreau
2000-11-10  9:44 ` Matti Aarnio
2000-11-10  9:57   ` Constantine Gavrilov
2000-11-10 10:14     ` Matti Aarnio
2000-11-10 10:22       ` Constantine Gavrilov
2000-11-10 10:51         ` Matti Aarnio
2000-11-10 19:11           ` Thomas Davis
2000-11-10 10:18 ` Constantine Gavrilov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).