From: Jens Axboe <axboe@suse.de>
To: Alexander Viro <viro@math.psu.edu>
Cc: Nate Eldredge <neldredge@hmc.edu>, linux-kernel@vger.kernel.org
Subject: Re: 2.4.2-ac3: loop threads in D state
Date: Mon, 26 Feb 2001 01:33:26 +0100 [thread overview]
Message-ID: <20010226013326.X7830@suse.de> (raw)
In-Reply-To: <20010226012430.V7830@suse.de> <Pine.GSO.4.21.0102251927170.26808-100000@weyl.math.psu.edu>
In-Reply-To: <Pine.GSO.4.21.0102251927170.26808-100000@weyl.math.psu.edu>; from viro@math.psu.edu on Sun, Feb 25, 2001 at 07:29:21PM -0500
On Sun, Feb 25 2001, Alexander Viro wrote:
> Erm... Jens, it really should be
> if (atomic_dec_and_test(...))
> up(...);
> not just
> atomic_dec(...);
> up(...);
>
> Otherwise you can end up with too early exit of loop_thread. Normally
> it would not matter, but in pathological cases...
How so? We dec it and up the semaphore, loop_thread runs until it's
done and ups lo_sem.
--
Jens Axboe
next prev parent reply other threads:[~2001-02-26 0:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-24 21:14 2.4.2-ac3: loop threads in D state Nate Eldredge
2001-02-25 22:33 ` Nate Eldredge
2001-02-25 22:39 ` Jens Axboe
2001-02-25 22:48 ` Alexander Viro
2001-02-26 0:24 ` Jens Axboe
2001-02-26 0:29 ` Alexander Viro
2001-02-26 0:33 ` Jens Axboe [this message]
2001-02-26 0:36 ` Alexander Viro
2001-02-26 0:39 ` Jens Axboe
2001-02-26 1:42 ` Alexander Viro
2001-02-26 0:40 ` Alexander Viro
2001-02-26 0:48 ` Jens Axboe
2001-02-26 0:53 ` Alexander Viro
2001-02-26 0:54 ` Jens Axboe
2001-02-27 19:11 ` Nate Eldredge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010226013326.X7830@suse.de \
--to=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=neldredge@hmc.edu \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).