linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Viro <viro@math.psu.edu>
To: Jens Axboe <axboe@suse.de>
Cc: Nate Eldredge <neldredge@hmc.edu>, linux-kernel@vger.kernel.org
Subject: Re: 2.4.2-ac3: loop threads in D state
Date: Sun, 25 Feb 2001 19:29:21 -0500 (EST)	[thread overview]
Message-ID: <Pine.GSO.4.21.0102251927170.26808-100000@weyl.math.psu.edu> (raw)
In-Reply-To: <20010226012430.V7830@suse.de>



On Mon, 26 Feb 2001, Jens Axboe wrote:

> On Sun, Feb 25 2001, Alexander Viro wrote:
> > Jens, you have a race in lo_clr_fd() (loop-6). I've put the fixed
> > variant on ftp.math.psu.edu/pub/viro/loop-S2.gz. Diff and you'll
> > see - it's in the very beginning of the lo_clr_fd().
> 
> Oops yeah you are right. Here's a diff of my current loop stuff
> against -ac4, Alan could you apply? Andrea suggested removing
> the loop private slab cache for buffer heads and just using the
> bh_cachep pool, and it seems like a good idea to me.

Erm... Jens, it really should be
	if (atomic_dec_and_test(...))
		up(...);
not just
	atomic_dec(...);
	up(...);

Otherwise you can end up with too early exit of loop_thread. Normally
it would not matter, but in pathological cases...


  reply	other threads:[~2001-02-26  0:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-02-24 21:14 2.4.2-ac3: loop threads in D state Nate Eldredge
2001-02-25 22:33 ` Nate Eldredge
2001-02-25 22:39   ` Jens Axboe
2001-02-25 22:48     ` Alexander Viro
2001-02-26  0:24       ` Jens Axboe
2001-02-26  0:29         ` Alexander Viro [this message]
2001-02-26  0:33           ` Jens Axboe
2001-02-26  0:36             ` Alexander Viro
2001-02-26  0:39               ` Jens Axboe
2001-02-26  1:42                 ` Alexander Viro
2001-02-26  0:40               ` Alexander Viro
2001-02-26  0:48                 ` Jens Axboe
2001-02-26  0:53                   ` Alexander Viro
2001-02-26  0:54                     ` Jens Axboe
2001-02-27 19:11   ` Nate Eldredge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.GSO.4.21.0102251927170.26808-100000@weyl.math.psu.edu \
    --to=viro@math.psu.edu \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neldredge@hmc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).