* [patch] 2.4.2: irq-driven lp stalls
@ 2001-02-27 22:04 Tim Waugh
0 siblings, 0 replies; only message in thread
From: Tim Waugh @ 2001-02-27 22:04 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-kernel
Hi Linus,
This patch seems to cure some printing stalls that some people have
been seeing. The down_trylock call isn't really needed there anyway.
Please apply.
Tim.
*/
2001-02-27 Tim Waugh <twaugh@redhat.com>
* drivers/parport/ieee1284_ops.c: Remove down_trylock call,
which seems to prevent stalls.
* drivers/parport/ChangeLog: Updated.
--- linux/drivers/parport/ieee1284_ops.c.sema Tue Feb 27 21:43:49 2001
+++ linux/drivers/parport/ieee1284_ops.c Tue Feb 27 21:44:16 2001
@@ -50,9 +50,6 @@
if (port->irq != PARPORT_IRQ_NONE) {
parport_enable_irq (port);
no_irq = 0;
-
- /* Clear out previous irqs. */
- while (!down_trylock (&port->physport->ieee1284.irq));
}
port->physport->ieee1284.phase = IEEE1284_PH_FWD_DATA;
--- linux/drivers/parport/ChangeLog.sema Tue Feb 27 21:44:21 2001
+++ linux/drivers/parport/ChangeLog Tue Feb 27 21:45:43 2001
@@ -0,0 +1,7 @@
+2001-02-27 Tim Waugh <twaugh@redhat.com>
+
+ * ieee1284_ops.c (parport_ieee1284_write_compat): Don't use
+ down_trylock to reset the IRQ count. Don't even use sema_init,
+ because it's not even necessary to reset the count. I can't
+ remember why we ever did.
+
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2001-02-27 22:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-02-27 22:04 [patch] 2.4.2: irq-driven lp stalls Tim Waugh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).