RE: binfmt_script and ^M

RE: binfmt_script and ^M

[Heusden, Folkert van]

> When running a script (perl in this case) that has DOS-style newlines
> (\r\n), Linux 2.4.2 can't find an interpreter because it doesn't
> recognize the \r.  The following patch should fix this (untested).

_should_ it work with the \r in it?

There might be a problem with your patch: at the '*)': if the '\n' is the
first character on the line, the cp-1 (which should be *(cp-1) I think)
would point before the buffer which can be un-allocated memory.



--- binfmt_script.c~	Mon Feb 26 17:42:09 2001
+++ binfmt_script.c	Tue Feb 27 13:39:47 2001
@@ -36,6 +36,8 @@
 	bprm->buf[BINPRM_BUF_SIZE - 1] = '\0';
 	if ((cp = strchr(bprm->buf, '\n')) == NULL)
 		cp = bprm->buf+BINPRM_BUF_SIZE-1;
+	if (cp - 1 == '\r')				<------- *)
+	  cp--;
 	*cp = '\0';
 	while (cp > bprm->buf) {
 		cp--;


Greetings,
Folkert van Heusden
[ www.vanheusden.com ]

Re: binfmt_script and ^M

[Ivo Timmermans]

Heusden, Folkert van wrote:
> > When running a script (perl in this case) that has DOS-style newlines
> > (\r\n), Linux 2.4.2 can't find an interpreter because it doesn't
> > recognize the \r.  The following patch should fix this (untested).
> 
> _should_ it work with the \r in it?

IMHO, yes.  This set of files were created on Windows, then zipped and
uploaded to a Linux server, unpacked.  This does not change the \r.

> There might be a problem with your patch: at the '*)': if the '\n' is the
> first character on the line, the cp-1 (which should be *(cp-1) I think)

You're right there.

> would point before the buffer which can be un-allocated memory.

No, the first two characters are always `#!'.

> +	if (cp - 1 == '\r')				<------- *)


-- 
Ivo Timmermans

Re: binfmt_script and ^M

[Jamie Lokier]

Ivo Timmermans wrote:
> > _should_ it work with the \r in it?
> 
> IMHO, yes.  This set of files were created on Windows, then zipped and
> uploaded to a Linux server, unpacked.  This does not change the \r.

Use `fromdos' to convert the files.  Or this little Perl gem, which
takes a list of files or standard input as argument:

#!/usr/bin/perl -pi
s/\r\n$/\n/

-- Jamie

Re: binfmt_script and ^M

[Don Dugger]

Isn't `perl' overkill?  Why not just:

	tr -d '\r'

On Tue, Feb 27, 2001 at 08:20:59PM +0100, Jamie Lokier wrote:
> Ivo Timmermans wrote:
> > > _should_ it work with the \r in it?
> > 
> > IMHO, yes.  This set of files were created on Windows, then zipped and
> > uploaded to a Linux server, unpacked.  This does not change the \r.
> 
> Use `fromdos' to convert the files.  Or this little Perl gem, which
> takes a list of files or standard input as argument:
> 
> #!/usr/bin/perl -pi
> s/\r\n$/\n/
> 
> -- Jamie
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Don Dugger
"Censeo Toto nos in Kansa esse decisse." - D. Gale
n0ano@valinux.com
Ph: 303/938-9838

[OT] Re: binfmt_script and ^M

[Tim Waugh]

On Tue, Feb 27, 2001 at 12:59:48PM -0700, Don Dugger wrote:

> Isn't `perl' overkill?  Why not just:
> 
> 	tr -d '\r'

while read line; do echo ${line%?}; done

Re: [OT] Re: binfmt_script and ^M

[Jamie Lokier]

Tim Waugh wrote:
> > Isn't `perl' overkill?  Why not just:
> > 
> > 	tr -d '\r'
> 
> while read line; do echo ${line%?}; done

And those can be convert a set of files as "fromdos *.c" can they?

:-)
-- Jamie

Re: binfmt_script and ^M

[Rogier Wolff]

Ivo Timmermans wrote:
> Heusden, Folkert van wrote:
> > > When running a script (perl in this case) that has DOS-style newlines
> > > (\r\n), Linux 2.4.2 can't find an interpreter because it doesn't
> > > recognize the \r.  The following patch should fix this (untested).
> > 
> > _should_ it work with the \r in it?
> 
> IMHO, yes.  This set of files were created on Windows, then zipped and
> uploaded to a Linux server, unpacked.  This does not change the \r.

Use the right option on "unzip" to unpack with cr/lf conversion.

Otherwise, use a script that does it afterwards. 

			Roger.

-- 
** R.E.Wolff@BitWizard.nl ** http://www.BitWizard.nl/ ** +31-15-2137555 **
*-- BitWizard writes Linux device drivers for any device you may have! --*
* There are old pilots, and there are bold pilots. 
* There are also old, bald pilots. 

Re: binfmt_script and ^M

[Bruce Harada]

On Tue, 27 Feb 2001 14:38:23 +0100
Ivo Timmermans <irt@cistron.nl> wrote:
> Heusden, Folkert van wrote:
> > > When running a script (perl in this case) that has DOS-style
> newlines
> > > (\r\n), Linux 2.4.2 can't find an interpreter because it doesn't
> > > recognize the \r.  The following patch should fix this (untested).
> > 
> > _should_ it work with the \r in it?
> 
> IMHO, yes.  This set of files were created on Windows, then zipped and
> uploaded to a Linux server, unpacked.  This does not change the \r.

Unzipping the files with the "-ll" option should fix that. There's no
particular reason why the kernel should handle CR+LF; LF has been the
end-of-line character for UN*X systems since Adam was a cowboy.
Changing it now would only lead to a situation where some things would
work with CR+LF and others wouldn't. Let's keep it simple...

--
Bruce Harada
bruce@ask.ne.jp