linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: Kernel diff_small_2.4.8pre2_2.4.8pre3
       [not found] <200107301808.f6UI8DL29566@athlon.random>
@ 2001-07-31  3:58 ` Andrea Arcangeli
  0 siblings, 0 replies; only message in thread
From: Andrea Arcangeli @ 2001-07-31  3:58 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

On Mon, Jul 30, 2001 at 08:08:13PM +0200, Andrea Arcangeli wrote:
> diff -urN 2.4.8pre2/include/asm-i386/softirq.h 2.4.8pre3/include/asm-i386/softirq.h
> --- 2.4.8pre2/include/asm-i386/softirq.h	Sun Jul 29 06:02:41 2001
> +++ 2.4.8pre3/include/asm-i386/softirq.h	Mon Jul 30 20:07:54 2001
> @@ -28,8 +28,6 @@
>  	unsigned long flags;						\
>  									\
>  	__save_flags(flags);						\
> -	if (!(flags & (1 << 9)))					\
> -		BUG();							\
>  	barrier();							\
>  	if (!--*ptr)							\
>  		__asm__ __volatile__ (					\

if you drop the bugcheck you should drop the __save_flags and flags too.

What was the problem with it? I seen a report from Chris but that sounds
like a bug in a caller of the the smp-call function (smp-call must be
run with irq enabled as it's written explicitly in the comment on top of
it).

Andrea

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2001-07-31  3:58 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <200107301808.f6UI8DL29566@athlon.random>
2001-07-31  3:58 ` Kernel diff_small_2.4.8pre2_2.4.8pre3 Andrea Arcangeli

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).