* drivers/ieee1394 duplicate symbol, 2.4.8-pre4
@ 2001-08-06 3:46 Keith Owens
2001-08-06 3:53 ` Ben Collins
0 siblings, 1 reply; 2+ messages in thread
From: Keith Owens @ 2001-08-06 3:46 UTC (permalink / raw)
To: linux-kernel, linux1394-devel
drivers/ieee1394/raw1394.c:spinlock_t host_info_lock = SPIN_LOCK_UNLOCKED;
drivers/ieee1394/nodemgr.c:spinlock_t host_info_lock = SPIN_LOCK_UNLOCKED;
when both raw1394 and nodemgr are linked into vmlinux, it gets
drivers/ieee1394/raw1394.o(.data+0x8): multiple definition of `host_info_lock'
drivers/ieee1394/ieee1394.o(.data+0x8c): first defined here
Either host_info_lock should be static or it should be defined as
extern in one source and referenced in the others.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: drivers/ieee1394 duplicate symbol, 2.4.8-pre4
2001-08-06 3:46 drivers/ieee1394 duplicate symbol, 2.4.8-pre4 Keith Owens
@ 2001-08-06 3:53 ` Ben Collins
0 siblings, 0 replies; 2+ messages in thread
From: Ben Collins @ 2001-08-06 3:53 UTC (permalink / raw)
To: Keith Owens; +Cc: linux-kernel, linux1394-devel
On Mon, Aug 06, 2001 at 01:46:40PM +1000, Keith Owens wrote:
> drivers/ieee1394/raw1394.c:spinlock_t host_info_lock = SPIN_LOCK_UNLOCKED;
> drivers/ieee1394/nodemgr.c:spinlock_t host_info_lock = SPIN_LOCK_UNLOCKED;
>
> when both raw1394 and nodemgr are linked into vmlinux, it gets
>
> drivers/ieee1394/raw1394.o(.data+0x8): multiple definition of `host_info_lock'
> drivers/ieee1394/ieee1394.o(.data+0x8c): first defined here
>
> Either host_info_lock should be static or it should be defined as
> extern in one source and referenced in the others.
It should be static. Thanks for the report. I believe this is fixed in
CVS, and if not, it will be soon.
Hopefully we'll get a chance to sync CVS to Linus before 2.4.8 final. If
not, I'll submit a patch for that bug atleast.
--
.----------=======-=-======-=========-----------=====------------=-=-----.
/ Ben Collins -- ...on that fantastic voyage... -- Debian GNU/Linux \
` bcollins@debian.org -- bcollins@openldap.org -- bcollins@linux.com '
`---=========------=======-------------=-=-----=-===-======-------=--=---'
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2001-08-06 3:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-08-06 3:46 drivers/ieee1394 duplicate symbol, 2.4.8-pre4 Keith Owens
2001-08-06 3:53 ` Ben Collins
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).