From: Richard Gooch <rgooch@ras.ucalgary.ca>
To: Alexander Viro <viro@math.psu.edu>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] one of $BIGNUM devfs races
Date: Tue, 7 Aug 2001 00:36:32 -0600 [thread overview]
Message-ID: <200108070636.f776aWi31626@vindaloo.ras.ucalgary.ca> (raw)
In-Reply-To: <Pine.GSO.4.21.0108070205370.16817-100000@weyl.math.psu.edu>
In-Reply-To: <200108070553.f775rQ631046@vindaloo.ras.ucalgary.ca> <Pine.GSO.4.21.0108070205370.16817-100000@weyl.math.psu.edu>
Alexander Viro writes:
>
>
> On Mon, 6 Aug 2001, Richard Gooch wrote:
>
> > Damn. I've just run into a snag. My read_inode() needs to dereference
> > inode->u.generic_ip, however, I can only initialise this *after* the
> > call to iget() finishes. Now, I could shoehorn my pointer into
> > inode->ino (thanks to it being an unsigned long), but that's pretty
> > gross.
> >
> > I also notice iget4() and the read_inode2() method, however, from the
> > comments, it looks like those are reiserfs-specific, and will die
> > soon. At the very least, it seems use thereof is discouraged.
> >
> > Suggestions?
>
> Lose ->read_inode(). Since your inode numbers are not stable across
> reboot you can't use iget for NFS-exporting devfs (even if you would
> want to export it in the first place). So there is no reason whatsoever
> to use it.
OK...
> Add put_inode: force_delete, into your super_operations and replace
> your call of iget() with
>
> inode = new_inode(sb);
> if (inode) {
> inode->i_ino = whatever;
> /* stuff you've used to do in devfs_read_inode */
> }
>
> Notice that here you have pointer to 'entry', so there is no problem
> with passing it. ->read_inode() simply goes away. Besides, that way
> you don't pollute icache hash chains - devfs inodes stay out of hash.
Um, what will happen to inode change events? What exactly is the
purpose of these hash chains?
Regards,
Richard....
Permanent: rgooch@atnf.csiro.au
Current: rgooch@ras.ucalgary.ca
next prev parent reply other threads:[~2001-08-07 6:36 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-06 11:58 [PATCH] one of $BIGNUM devfs races Alexander Viro
2001-08-06 16:47 ` Richard Gooch
2001-08-06 16:56 ` Rik van Riel
2001-08-06 17:11 ` Richard Gooch
2001-08-06 23:50 ` Richard Gooch
2001-08-07 0:34 ` Alexander Viro
2001-08-07 0:51 ` Richard Gooch
2001-08-07 1:10 ` Alexander Viro
2001-08-07 1:27 ` Richard Gooch
2001-08-07 1:42 ` Alexander Viro
2001-08-07 2:00 ` Richard Gooch
2001-08-07 2:15 ` Alexander Viro
2001-08-07 5:17 ` Richard Gooch
2001-08-07 5:28 ` Alexander Viro
2001-08-07 10:21 ` Anton Altaparmakov
2001-08-07 17:09 ` Richard Gooch
2001-08-07 17:27 ` Arjan van de Ven
2001-08-07 17:28 ` Richard Gooch
2001-08-07 5:53 ` Richard Gooch
2001-08-07 6:23 ` Alexander Viro
2001-08-07 6:36 ` Richard Gooch [this message]
2001-08-07 6:40 ` Alexander Viro
2001-08-07 6:47 ` Richard Gooch
2001-08-07 7:31 ` Alexander Viro
2001-08-07 18:11 ` Richard Gooch
2001-08-07 18:23 ` Alexander Viro
2001-08-07 18:55 ` Richard Gooch
2001-08-07 19:10 ` Alexander Viro
2001-08-07 22:13 ` Richard Gooch
2001-08-06 23:59 Alan Cox
[not found] ` <no.id>
2001-08-06 23:54 ` Alan Cox
2001-08-06 23:55 ` Richard Gooch
2001-08-06 23:59 ` Richard Gooch
2001-08-07 16:22 ` Alan Cox
2001-08-07 19:04 ` Alan Cox
2001-08-07 19:16 ` Alexander Viro
2001-08-08 21:16 ` H. Peter Anvin
2001-08-08 21:47 ` Alexander Viro
2001-08-08 23:29 ` Richard Gooch
2001-08-07 19:09 ` Richard Gooch
2001-08-07 19:20 ` Alexander Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200108070636.f776aWi31626@vindaloo.ras.ucalgary.ca \
--to=rgooch@ras.ucalgary.ca \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).