Re: [PATCH] one of $BIGNUM devfs races

From: Alexander Viro <viro@math.psu.edu>
To: Richard Gooch <rgooch@ras.ucalgary.ca>
Cc: Linus Torvalds <torvalds@transmeta.com>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] one of $BIGNUM devfs races
Date: Mon, 6 Aug 2001 21:10:11 -0400 (EDT)	[thread overview]
Message-ID: <Pine.GSO.4.21.0108062053220.16817-100000@weyl.math.psu.edu> (raw)
In-Reply-To: <200108070051.f770pji27036@vindaloo.ras.ucalgary.ca>

On Mon, 6 Aug 2001, Richard Gooch wrote:

> More importantly, the loop you used doesn't protect insertions into
> the table. So it's not safe on SMP.

Nope.  Allocation of entry itself is moved ahead of the loop, so
we insert immediately after expanding the thing.

> > PS: ObYourPropertyManager: karmic retribution?
> 
> Um, retribution for putting in an awful lot of time developing devfs
> (despite extreme hostility), at considerable personal sacrifice, and
> being patient and civilised to those who flamed against it? My, how
> I've been such a horrible person.

<tongue-in-cheek>
Nah, not that. Not plugging the holes that need to be plugged. Admit
it, there is some poetic justice in the situation.
</tongue-in-cheek>

As for the repugnant comments - IMO your "On the top of that, I have
a life" used in the context it was used in counts pretty high on that
scale. You know, you are _not_ unique in that respect.

Whatever.  I just hope that this time all that mess will be fixed and by
now I really don't care who does it and what does it take.