linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] include/linux/ghash.h (2.4.8 & 2.4.9)
@ 2001-08-29 14:02 Lukas Ruf
  0 siblings, 0 replies; only message in thread
From: Lukas Ruf @ 2001-08-29 14:02 UTC (permalink / raw)
  To: Linux Kernel ml

[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]

Dear all,

please find attached two patches for include/linux/ghash.h against 2.4.8
and 2.4.9 (even if they seem to be the same ,-).

The issue, I struggled over:
in find_##NAME_hash() the macro argument was written in lower case.
Therefore, a module that makes use of ghash.h cannot be depmod'd as hashfn
is a not resolved symbol.

The provided patch fixes this small typo by that it changes hashfn to
HASHFN, as required by the macro definition.

I missed this correction in 2.4.8 (up to ac12) as well as in 2.4.9
(vanilla).  Please drop a line if I misunderstood something.  Otherwise
include the patch in the kernel, please.

Any comments are welcome!

Lukas

-- 
Lukas Ruf                        Swiss Federal Institute of Technology
Office: ETZ-G61.2                             Computer Engineering and
Phone: +41/1/632 7312                        Networks Laboratory (TIK)
Fax:   +41/1/632 1035                                      ETH Zentrum
PGP 2.6: ID D20BA2ED;                                    Gloriastr. 35
Fingerprint 6323 B9BC 9C8E 6563  B477 BADD FEA6 E6B7    CH-8092 Zurich

[-- Attachment #2: linux-2.4.8-ghash.diff --]
[-- Type: text/plain, Size: 637 bytes --]

--- linux,orig/include/linux/ghash.h	Mon Jul  7 17:24:28 1997
+++ linux/include/linux/ghash.h	Wed Aug 29 14:46:15 2001
@@ -106,7 +106,7 @@
 \
 LINKAGE TYPE * find_##NAME##_hash(struct NAME##_table * tbl, KEYTYPE pos)\
 {\
-	int ix = hashfn(pos);\
+	int ix = HASHFN(pos);\
 	TYPE * ptr = tbl->hashtable[ix];\
 	while(ptr && KEYCMP(ptr->KEY, pos))\
 		ptr = ptr->PTRS.next_hash;\
@@ -206,7 +206,7 @@
 \
 LINKAGE TYPE * find_##NAME##_hash(struct NAME##_table * tbl, KEYTYPE pos)\
 {\
-	int ix = hashfn(pos);\
+	int ix = HASHFN(pos);\
 	TYPE * ptr = tbl->hashtable[ix];\
 	while(ptr && KEYCMP(ptr->KEY, pos))\
 		ptr = ptr->PTRS.next_hash;\

[-- Attachment #3: linux-2.4.9-ghash.diff --]
[-- Type: text/plain, Size: 637 bytes --]

--- linux/include/linux/ghash.h,orig	Wed Aug 29 15:53:29 2001
+++ linux/include/linux/ghash.h	Wed Aug 29 15:54:11 2001
@@ -106,7 +106,7 @@
 \
 LINKAGE TYPE * find_##NAME##_hash(struct NAME##_table * tbl, KEYTYPE pos)\
 {\
-	int ix = hashfn(pos);\
+	int ix = HASHFN(pos);\
 	TYPE * ptr = tbl->hashtable[ix];\
 	while(ptr && KEYCMP(ptr->KEY, pos))\
 		ptr = ptr->PTRS.next_hash;\
@@ -206,7 +206,7 @@
 \
 LINKAGE TYPE * find_##NAME##_hash(struct NAME##_table * tbl, KEYTYPE pos)\
 {\
-	int ix = hashfn(pos);\
+	int ix = HASHFN(pos);\
 	TYPE * ptr = tbl->hashtable[ix];\
 	while(ptr && KEYCMP(ptr->KEY, pos))\
 		ptr = ptr->PTRS.next_hash;\

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2001-08-29 14:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-08-29 14:02 [PATCH] include/linux/ghash.h (2.4.8 & 2.4.9) Lukas Ruf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).