* Re: 2.4.9-ac4: undefined reference pgtable_cache_init
2001-08-30 16:05 ` Frank Davis
@ 2001-08-30 15:17 ` Paul Larson
2001-08-30 22:25 ` Russell King
0 siblings, 1 reply; 4+ messages in thread
From: Paul Larson @ 2001-08-30 15:17 UTC (permalink / raw)
To: Russell King; +Cc: Frank Davis, linux-kernel, Alan Cox
On 30 Aug 2001 17:26:12 +0100, Russell King wrote:
> On Thu, Aug 30, 2001 at 12:05:59PM -0400, Frank Davis wrote:
> > Hello,
> > During make bzImage, I received the following:
> >
> > init/main.o: In function 'start_kernel'
> > init/main.o(.text.init+0x842): undefined reference to 'pgtable_cache_init'
>
> Which architecture are you building for?
I've seen this as well on i386. It crops up when you are using HIGHMEM.
In include/asm-i386/pgtable.h you declare pgtable_cache_init if HIGHMEM
is on, or define it to the empty while loop if not. It really needs to
be calling init_pae_pgd_cache instead though. Try this patch against
2.4.9-ac4. I don't know if changing the name of init_pae_pgd_cache was
the Right Thing (tm) to do, but it worked for me. It's not getting
called anywhere else anyways.
-Paul Larson
diff -urN linux-2.4.9-ac4/arch/i386/mm/init.c linux-new/arch/i386/mm/init.c
--- linux-2.4.9-ac4/arch/i386/mm/init.c Thu Aug 30 14:09:00 2001
+++ linux-new/arch/i386/mm/init.c Thu Aug 30 15:01:12 2001
@@ -583,7 +583,7 @@
struct kmem_cache_s *pae_pgd_cachep;
-void __init init_pae_pgd_cache(void)
+void __init pgtable_cache_init(void)
{
/*
* PAE pgds must be 16-byte aligned:
^ permalink raw reply [flat|nested] 4+ messages in thread
* 2.4.9-ac4: undefined reference pgtable_cache_init
@ 2001-08-30 16:05 ` Frank Davis
2001-08-30 15:17 ` Paul Larson
0 siblings, 1 reply; 4+ messages in thread
From: Frank Davis @ 2001-08-30 16:05 UTC (permalink / raw)
To: linux-kernel; +Cc: Alan Cox
Hello,
During make bzImage, I received the following:
init/main.o: In function 'start_kernel'
init/main.o(.text.init+0x842): undefined reference to 'pgtable_cache_init'
make: *** [vmlinux] Error 1
Regards,
Frank
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 2.4.9-ac4: undefined reference pgtable_cache_init
2001-08-30 16:05 ` Frank Davis
@ 2001-08-30 16:26 Russell King
2001-08-30 16:05 ` Frank Davis
0 siblings, 1 reply; 4+ messages in thread
From: Russell King @ 2001-08-30 16:26 UTC (permalink / raw)
To: Frank Davis; +Cc: linux-kernel, Alan Cox
On Thu, Aug 30, 2001 at 12:05:59PM -0400, Frank Davis wrote:
> Hello,
> During make bzImage, I received the following:
>
> init/main.o: In function 'start_kernel'
> init/main.o(.text.init+0x842): undefined reference to 'pgtable_cache_init'
Which architecture are you building for?
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 2.4.9-ac4: undefined reference pgtable_cache_init
2001-08-30 15:17 ` Paul Larson
@ 2001-08-30 22:25 ` Russell King
0 siblings, 0 replies; 4+ messages in thread
From: Russell King @ 2001-08-30 22:25 UTC (permalink / raw)
To: Paul Larson; +Cc: Frank Davis, linux-kernel, Alan Cox
On Thu, Aug 30, 2001 at 03:17:36PM +0000, Paul Larson wrote:
> I've seen this as well on i386. It crops up when you are using HIGHMEM.
> In include/asm-i386/pgtable.h you declare pgtable_cache_init if HIGHMEM
> is on, or define it to the empty while loop if not. It really needs to
> be calling init_pae_pgd_cache instead though. Try this patch against
> 2.4.9-ac4. I don't know if changing the name of init_pae_pgd_cache was
> the Right Thing (tm) to do, but it worked for me. It's not getting
> called anywhere else anyways.
It got changed because we don't want to add multiple architecture
specific functions to init/main.c, but rather have one generic call
which any architecture can use for this type of thing.
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2001-08-30 23:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-08-30 16:26 2.4.9-ac4: undefined reference pgtable_cache_init Russell King
2001-08-30 16:05 ` Frank Davis
2001-08-30 15:17 ` Paul Larson
2001-08-30 22:25 ` Russell King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).