From: Andres Salomon <saloma@rpi.edu>
To: linux-kernel@vger.kernel.org
Subject: [patch] 3c515 warnings
Date: Sun, 16 Sep 2001 18:46:51 -0400 [thread overview]
Message-ID: <20010916184651.A703@mp3revolution.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 614 bytes --]
I'm not sure what happened to the full_duplex variable in 3c515.c, but
it was ignored by the driver anyways. The attached patch removes the
MODULE_PARM references to the variable (which would cause a warning
to be spewed when you tried to modprobe the driver). Diff'd against
2.4.10-pre9, please apply.
BTW, does anyone actually use this driver? I'm cleaning it up a bit,
and possibly (if I have the time) syncing w/ becker's latest;
if anyone's interested in testing it out, let me know.
--
"Any OS is only as good as its admin, and you obviously suck."
-- Ian Gulliver, http://orbz.org/mail/mansunix.txt
[-- Attachment #2: duplex_arg.diff --]
[-- Type: text/plain, Size: 767 bytes --]
--- linux/drivers/net/3c515.c Sun Sep 16 00:11:42 2001
+++ linux.dilinger/drivers/net/3c515.c Sun Sep 16 12:49:56 2001
@@ -84,12 +84,10 @@
MODULE_DESCRIPTION("3Com 3c515 Corkscrew driver");
MODULE_PARM(debug, "i");
MODULE_PARM(options, "1-" __MODULE_STRING(8) "i");
-MODULE_PARM(full_duplex, "1-" __MODULE_STRING(8) "i");
MODULE_PARM(rx_copybreak, "i");
MODULE_PARM(max_interrupt_work, "i");
MODULE_PARM_DESC(debug, "3c515 debug level (0-6)");
MODULE_PARM_DESC(options, "3c515: Bits 0-2: media type, bit 3: full duplex, bit 4: bus mastering");
-MODULE_PARM_DESC(full_duplex, "(ignored)");
MODULE_PARM_DESC(rx_copybreak, "3c515 copy breakpoint for copy-only-tiny-frames");
MODULE_PARM_DESC(max_interrupt_work, "3c515 maximum events handled per interrupt");
next reply other threads:[~2001-09-16 22:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-16 22:46 Andres Salomon [this message]
2001-09-22 11:47 [patch] 3c515 warnings Per Jessen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010916184651.A703@mp3revolution.net \
--to=saloma@rpi.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).