From: Chris Wright <chris@wirex.com>
To: David Dyck <dcd@tc.fluke.com>
Cc: linux-kernel@vger.kernel.org, Jens Axboe <axboe@suse.de>,
Linus Torvalds <torvalds@transmeta.com>
Subject: Re: 2.4.14 doesn't compile: deactivate_page not defined in loop.c
Date: Mon, 5 Nov 2001 17:35:17 -0800 [thread overview]
Message-ID: <20011105173517.A22095@figure1.int.wirex.com> (raw)
In-Reply-To: <Pine.LNX.4.33.0111051654140.4708-100000@dd.tc.fluke.com>
In-Reply-To: <Pine.LNX.4.33.0111051654140.4708-100000@dd.tc.fluke.com>; from dcd@tc.fluke.com on Mon, Nov 05, 2001 at 04:57:18PM -0800
* David Dyck (dcd@tc.fluke.com) wrote:
>
>
> drivers/block/block.o: In function `lo_send':
> drivers/block/block.o(.text+0x8ad9): undefined reference to `deactivate_page'
> drivers/block/block.o(.text+0x8b19): undefined reference to `deactivate_page'
>
>
> a grep from deactivate_page only shows up in linux/drivers/block/loop.c
appears that deactivate_page was removed (see patch-2.4.14). the patch
below Works For Me with limited testing (mount loop back, write,
unmount, remount, stuff i wrote is still there ;-). YMMV.
cheers,
-chris
diff -X /home/chris/dontdiff -Naur linux-2.4.14/drivers/block/loop.c linux-2.4.14-loop/drivers/block/loop.c
--- linux-2.4.14/drivers/block/loop.c Thu Oct 25 13:58:34 2001
+++ linux-2.4.14-loop/drivers/block/loop.c Mon Nov 5 17:06:08 2001
@@ -207,7 +207,6 @@
index++;
pos += size;
UnlockPage(page);
- deactivate_page(page);
page_cache_release(page);
}
return 0;
@@ -218,7 +217,6 @@
kunmap(page);
unlock:
UnlockPage(page);
- deactivate_page(page);
page_cache_release(page);
fail:
return -1;
next prev parent reply other threads:[~2001-11-06 1:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-06 0:57 2.4.14 doesn't compile: deactivate_page not defined in loop.c David Dyck
2001-11-06 1:30 ` Erik Andersen
2001-11-06 1:35 ` Chris Wright [this message]
2001-11-06 1:50 ` Andrea Arcangeli
2001-11-06 2:14 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011105173517.A22095@figure1.int.wirex.com \
--to=chris@wirex.com \
--cc=axboe@suse.de \
--cc=dcd@tc.fluke.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).