From: Linus Torvalds <torvalds@transmeta.com>
To: Andrea Arcangeli <andrea@suse.de>
Cc: David Dyck <dcd@tc.fluke.com>, <linux-kernel@vger.kernel.org>,
Jens Axboe <axboe@suse.de>
Subject: Re: 2.4.14 doesn't compile: deactivate_page not defined in loop.c
Date: Mon, 5 Nov 2001 18:14:47 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.33.0111051811560.1710-100000@penguin.transmeta.com> (raw)
In-Reply-To: <20011106025056.D31912@athlon.random>
On Tue, 6 Nov 2001, Andrea Arcangeli wrote:
>
> no idea why deactivate_page disappeared, it made sense to deactivate the
> lower level cache
Answer me this:
How would it get activated in the first place?
Right. By being accessed multiple times, that's how. Which you claim it
won't be - in which case de-activating it is a no-op, and unnecessary.
Now, there's another possibility: that it _does_ get accessed multiple
times, _despite_ being the lower-level cache. In which case de-activating
it is the wrong thing to do.
So we basically have two cases. And in neither case does it make sense to
de-activate the page. Eh?
Linus
prev parent reply other threads:[~2001-11-06 2:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-06 0:57 2.4.14 doesn't compile: deactivate_page not defined in loop.c David Dyck
2001-11-06 1:30 ` Erik Andersen
2001-11-06 1:35 ` Chris Wright
2001-11-06 1:50 ` Andrea Arcangeli
2001-11-06 2:14 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.33.0111051811560.1710-100000@penguin.transmeta.com \
--to=torvalds@transmeta.com \
--cc=andrea@suse.de \
--cc=axboe@suse.de \
--cc=dcd@tc.fluke.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).