* Stuff that needs fixing in 2.5.1-pre4
@ 2001-11-30 2:49 Udo A. Steinberg
2001-11-30 7:40 ` Jens Axboe
0 siblings, 1 reply; 5+ messages in thread
From: Udo A. Steinberg @ 2001-11-30 2:49 UTC (permalink / raw)
To: Linux Kernel
Hi all,
Below a few things that should probably be fixed in the current 2.5. tree.
Regards,
Udo.
drivers/ide/
pdc202xx.c: In function `config_chipset_for_dma':
pdc202xx.c:530: warning: `drive_pci' might be used uninitialized in this function
fs/fat/
inode.c: In function `fat_writepage':
inode.c:859: warning: passing arg 2 of `block_write_full_page' from incompatible pointer type
inode.c: In function `fat_readpage':
inode.c:863: warning: passing arg 2 of `block_read_full_page' from incompatible pointer type
inode.c: In function `fat_prepare_write':
inode.c:868: warning: passing arg 4 of `cont_prepare_write' from incompatible pointer type
inode.c: In function `_fat_bmap':
inode.c:872: warning: passing arg 3 of `generic_block_bmap' from incompatible pointer type
/fs/minix/
In file included from itree_v1.c:47:
itree_common.c: In function `truncate':
itree_common.c:305: warning: passing arg 3 of `block_truncate_page' from incompatible pointer type
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Stuff that needs fixing in 2.5.1-pre4
2001-11-30 2:49 Stuff that needs fixing in 2.5.1-pre4 Udo A. Steinberg
@ 2001-11-30 7:40 ` Jens Axboe
2001-11-30 13:54 ` [PATCH] " Udo A. Steinberg
0 siblings, 1 reply; 5+ messages in thread
From: Jens Axboe @ 2001-11-30 7:40 UTC (permalink / raw)
To: Udo A. Steinberg; +Cc: Linux Kernel
On Fri, Nov 30 2001, Udo A. Steinberg wrote:
>
> Hi all,
>
> Below a few things that should probably be fixed in the current 2.5. tree.
Make the get_block long argument for block a sector_t. Once you have
that warning free, send on the fix.
--
Jens Axboe
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] Re: Stuff that needs fixing in 2.5.1-pre4
2001-11-30 7:40 ` Jens Axboe
@ 2001-11-30 13:54 ` Udo A. Steinberg
2001-11-30 14:17 ` [Correct PATCH] " Udo A. Steinberg
0 siblings, 1 reply; 5+ messages in thread
From: Udo A. Steinberg @ 2001-11-30 13:54 UTC (permalink / raw)
To: Jens Axboe; +Cc: Linus Torvalds, Linux Kernel
Jens Axboe wrote:
>
> Make the get_block long argument for block a sector_t. Once you have
> that warning free, send on the fix.
Thanks for the tip. Here's a patch against 2.5.1-pre4 that fixes it.
Regards,
Udo.
diff -urN -X dontdiff linux/fs/fat/file.c linux-vanilla/fs/fat/file.c
--- linux/fs/fat/file.c Fri Nov 30 14:35:16 2001
+++ linux-vanilla/fs/fat/file.c Sun Aug 12 19:56:56 2001
@@ -48,7 +48,7 @@
}
-int fat_get_block(struct inode *inode, sector_t iblock, struct buffer_head *bh_result, int create)
+int fat_get_block(struct inode *inode, long iblock, struct buffer_head *bh_result, int create)
{
struct super_block *sb = inode->i_sb;
unsigned long phys;
diff -urN -X dontdiff linux/fs/minix/itree_common.c linux-vanilla/fs/minix/itree_common.c
--- linux/fs/minix/itree_common.c Fri Nov 30 14:39:37 2001
+++ linux-vanilla/fs/minix/itree_common.c Fri Sep 7 18:45:51 2001
@@ -140,7 +140,7 @@
return -EAGAIN;
}
-static inline int get_block(struct inode * inode, sector_t block,
+static inline int get_block(struct inode * inode, long block,
struct buffer_head *bh_result, int create)
{
int err = -EIO;
diff -urN -X dontdiff linux/include/linux/msdos_fs.h linux-vanilla/include/linux/msdos_fs.h
--- linux/include/linux/msdos_fs.h Fri Nov 30 14:36:45 2001
+++ linux-vanilla/include/linux/msdos_fs.h Fri Oct 12 22:48:42 2001
@@ -273,7 +273,7 @@
extern struct inode_operations fat_file_inode_operations;
extern ssize_t fat_file_read(struct file *filp, char *buf, size_t count,
loff_t *ppos);
-extern int fat_get_block(struct inode *inode, sector_t iblock,
+extern int fat_get_block(struct inode *inode, long iblock,
struct buffer_head *bh_result, int create);
extern ssize_t fat_file_write(struct file *filp, const char *buf, size_t count,
loff_t *ppos);
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Correct PATCH] Re: Stuff that needs fixing in 2.5.1-pre4
2001-11-30 13:54 ` [PATCH] " Udo A. Steinberg
@ 2001-11-30 14:17 ` Udo A. Steinberg
2001-11-30 19:35 ` Jens Axboe
0 siblings, 1 reply; 5+ messages in thread
From: Udo A. Steinberg @ 2001-11-30 14:17 UTC (permalink / raw)
To: Jens Axboe; +Cc: Linus Torvalds, Linux Kernel
"Udo A. Steinberg" wrote:
>
> Thanks for the tip. Here's a patch against 2.5.1-pre4 that fixes it.
I just noticed that my patch is reversed, so please apply it with -R or
alternatively try this fixed version.
-Udo.
diff -urN -X dontdiff linux-vanilla/fs/fat/file.c linux/fs/fat/file.c
--- linux-vanilla/fs/fat/file.c Sun Aug 12 19:56:56 2001
+++ linux/fs/fat/file.c Fri Nov 30 14:35:16 2001
@@ -48,7 +48,7 @@
}
-int fat_get_block(struct inode *inode, long iblock, struct buffer_head *bh_result, int create)
+int fat_get_block(struct inode *inode, sector_t iblock, struct buffer_head *bh_result, int create)
{
struct super_block *sb = inode->i_sb;
unsigned long phys;
diff -urN -X dontdiff linux-vanilla/fs/minix/itree_common.c linux/fs/minix/itree_common.c
--- linux-vanilla/fs/minix/itree_common.c Fri Sep 7 18:45:51 2001
+++ linux/fs/minix/itree_common.c Fri Nov 30 14:39:37 2001
@@ -140,7 +140,7 @@
return -EAGAIN;
}
-static inline int get_block(struct inode * inode, long block,
+static inline int get_block(struct inode * inode, sector_t block,
struct buffer_head *bh_result, int create)
{
int err = -EIO;
diff -urN -X dontdiff linux-vanilla/include/linux/msdos_fs.h linux/include/linux/msdos_fs.h
--- linux-vanilla/include/linux/msdos_fs.h Fri Oct 12 22:48:42 2001
+++ linux/include/linux/msdos_fs.h Fri Nov 30 14:36:45 2001
@@ -273,7 +273,7 @@
extern struct inode_operations fat_file_inode_operations;
extern ssize_t fat_file_read(struct file *filp, char *buf, size_t count,
loff_t *ppos);
-extern int fat_get_block(struct inode *inode, long iblock,
+extern int fat_get_block(struct inode *inode, sector_t iblock,
struct buffer_head *bh_result, int create);
extern ssize_t fat_file_write(struct file *filp, const char *buf, size_t count,
loff_t *ppos);
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Correct PATCH] Re: Stuff that needs fixing in 2.5.1-pre4
2001-11-30 14:17 ` [Correct PATCH] " Udo A. Steinberg
@ 2001-11-30 19:35 ` Jens Axboe
0 siblings, 0 replies; 5+ messages in thread
From: Jens Axboe @ 2001-11-30 19:35 UTC (permalink / raw)
To: Udo A. Steinberg; +Cc: Linus Torvalds, Linux Kernel
On Fri, Nov 30 2001, Udo A. Steinberg wrote:
> "Udo A. Steinberg" wrote:
> >
> > Thanks for the tip. Here's a patch against 2.5.1-pre4 that fixes it.
>
> I just noticed that my patch is reversed, so please apply it with -R or
> alternatively try this fixed version.
Looks good.
--
Jens Axboe
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2001-11-30 19:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-11-30 2:49 Stuff that needs fixing in 2.5.1-pre4 Udo A. Steinberg
2001-11-30 7:40 ` Jens Axboe
2001-11-30 13:54 ` [PATCH] " Udo A. Steinberg
2001-11-30 14:17 ` [Correct PATCH] " Udo A. Steinberg
2001-11-30 19:35 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).