[PATCH] Suppress compilation warnings on big endian platform for reiserfs

[PATCH] Suppress compilation warnings on big endian platform for reiserfs

[Oleg Drokin]

[-- Attachment #1: Type: text/plain, Size: 41 bytes --]

Hello!

    Please apply.

Bye,
    Oleg

[-- Attachment #2: big-endian-const.diff --]
[-- Type: text/plain, Size: 1071 bytes --]

--- linux/include/linux/reiserfs_fs.h.orig	Wed Jan  9 12:03:13 2002
+++ linux/include/linux/reiserfs_fs.h	Wed Jan  9 16:57:37 2002
@@ -244,9 +244,9 @@
     __u64 linear;
 } __attribute__ ((__packed__)) offset_v2_esafe_overlay;
 
-static inline __u16 offset_v2_k_type( struct offset_v2 *v2 )
+static inline __u16 offset_v2_k_type( const struct offset_v2 *v2 )
 {
-    offset_v2_esafe_overlay tmp = *(offset_v2_esafe_overlay *)v2;
+    offset_v2_esafe_overlay tmp = *(const constoffset_v2_esafe_overlay *)v2;
     tmp.linear = le64_to_cpu( tmp.linear );
     return (tmp.offset_v2.k_type <= TYPE_MAXTYPE)?tmp.offset_v2.k_type:TYPE_ANY;
 }
@@ -259,9 +259,9 @@
     tmp->linear = le64_to_cpu(tmp->linear);
 }
  
-static inline loff_t offset_v2_k_offset( struct offset_v2 *v2 )
+static inline loff_t offset_v2_k_offset( const struct offset_v2 *v2 )
 {
-    offset_v2_esafe_overlay tmp = *(offset_v2_esafe_overlay *)v2;
+    offset_v2_esafe_overlay tmp = *(const offset_v2_esafe_overlay *)v2;
     tmp.linear = le64_to_cpu( tmp.linear );
     return tmp.offset_v2.k_offset;
 }

Re: [reiserfs-dev] [PATCH] Suppress compilation warnings on big endian platform for reiserfs

[Oleg Drokin]

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

Hello!

    Argh! Stupid typo have flipped into the previous incarnation of this patch, so here is correct one.
    Please apply this one.

Bye,
    Oleg
On Wed, Jan 09, 2002 at 05:03:03PM +0300, Oleg Drokin wrote:
>     Please apply.

[-- Attachment #2: big-endian-const.diff --]
[-- Type: text/plain, Size: 1066 bytes --]

--- linux/include/linux/reiserfs_fs.h.orig	Wed Jan  9 12:03:13 2002
+++ linux/include/linux/reiserfs_fs.h	Wed Jan  9 16:57:37 2002
@@ -244,9 +244,9 @@
     __u64 linear;
 } __attribute__ ((__packed__)) offset_v2_esafe_overlay;
 
-static inline __u16 offset_v2_k_type( struct offset_v2 *v2 )
+static inline __u16 offset_v2_k_type( const struct offset_v2 *v2 )
 {
-    offset_v2_esafe_overlay tmp = *(offset_v2_esafe_overlay *)v2;
+    offset_v2_esafe_overlay tmp = *(const offset_v2_esafe_overlay *)v2;
     tmp.linear = le64_to_cpu( tmp.linear );
     return (tmp.offset_v2.k_type <= TYPE_MAXTYPE)?tmp.offset_v2.k_type:TYPE_ANY;
 }
@@ -259,9 +259,9 @@
     tmp->linear = le64_to_cpu(tmp->linear);
 }
  
-static inline loff_t offset_v2_k_offset( struct offset_v2 *v2 )
+static inline loff_t offset_v2_k_offset( const struct offset_v2 *v2 )
 {
-    offset_v2_esafe_overlay tmp = *(offset_v2_esafe_overlay *)v2;
+    offset_v2_esafe_overlay tmp = *(const offset_v2_esafe_overlay *)v2;
     tmp.linear = le64_to_cpu( tmp.linear );
     return tmp.offset_v2.k_offset;
 }

Re: [reiserfs-dev] [PATCH] Suppress compilation warnings on big endian platform for reiserfs

[Marcelo Tosatti]

Oleg, 

Can you please queue all of this patches for the next -pre1 in one big
update instead sending me a lot of daily small 

On Wed, 9 Jan 2002, Oleg Drokin wrote:

> Hello!
> 
>     Argh! Stupid typo have flipped into the previous incarnation of this patch, so here is correct one.
>     Please apply this one.
> 
> Bye,
>     Oleg
> On Wed, Jan 09, 2002 at 05:03:03PM +0300, Oleg Drokin wrote:
> >     Please apply.
> 

Re: [reiserfs-dev] [PATCH] Suppress compilation warnings on big endian platform for reiserfs

[Marcelo Tosatti]

Oops, pressed wrong key, sorry. ;) 

Well, keeping with the story... Can you please queue all of this patches
for the next -pre1 in one big update instead sending me a lot of daily
small patches ? 

I will obviously accept straight bugfixes at virtually any time.

On Wed, 9 Jan 2002, Marcelo Tosatti wrote:

> 
> Oleg, 
> 
> Can you please queue all of this patches for the next -pre1 in one big
> update instead sending me a lot of daily small 
> 
> On Wed, 9 Jan 2002, Oleg Drokin wrote:
> 
> > Hello!
> > 
> >     Argh! Stupid typo have flipped into the previous incarnation of this patch, so here is correct one.
> >     Please apply this one.
> > 
> > Bye,
> >     Oleg
> > On Wed, Jan 09, 2002 at 05:03:03PM +0300, Oleg Drokin wrote:
> > >     Please apply.
> > 
> 
> 

Re: [reiserfs-dev] [PATCH] Suppress compilation warnings on big endian platform for reiserfs

[Marcelo Tosatti]

On Wed, 9 Jan 2002, Oleg Drokin wrote:

> Hello!
> 
>    Sure, I can. Reason for sending small patches, is because Linus have requested people to send stuff in that way.
>
>    BTW, do you mean you won't accept any more patches until 2.4.19-pre1? (or what -pre1 do you mean?)

No, I'm just saying that you should send me non-bugfixes patches on
-pre1 kernels.

Thanks.

Re: [reiserfs-dev] [PATCH] Suppress compilation warnings on big endian platform for reiserfs

[Oleg Drokin]

Hello!

   Sure, I can. Reason for sending small patches, is because Linus have requested people to send stuff in that way.
   BTW, do you mean you won't accept any more patches until 2.4.19-pre1? (or what -pre1 do you mean?)

Bye,
    Oleg
On Wed, Jan 09, 2002 at 01:44:53PM -0200, Marcelo Tosatti wrote:
> 
> Oleg, 
> 
> Can you please queue all of this patches for the next -pre1 in one big
> update instead sending me a lot of daily small 
> 
> On Wed, 9 Jan 2002, Oleg Drokin wrote:
> 
> > Hello!
> > 
> >     Argh! Stupid typo have flipped into the previous incarnation of this patch, so here is correct one.
> >     Please apply this one.
> > 
> > Bye,
> >     Oleg
> > On Wed, Jan 09, 2002 at 05:03:03PM +0300, Oleg Drokin wrote:
> > >     Please apply.
> > 
> 

Re: [reiserfs-dev] [PATCH] Suppress compilation warnings on big endian platform for reiserfs

[Oleg Drokin]

Hello!

On Wed, Jan 09, 2002 at 01:56:02PM -0200, Marcelo Tosatti wrote:

> >    BTW, do you mean you won't accept any more patches until 2.4.19-pre1? (or what -pre1 do you mean?)
> No, I'm just saying that you should send me non-bugfixes patches on
> -pre1 kernels.

Ah, ok.

Bye,
    Oleg