linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mikael Pettersson <mikpe@csd.uu.se>
To: marcelo@conectiva.com.br
Cc: linux-kernel@vger.kernel.org
Subject: Re: Linux 2.4.19-pre3
Date: Tue, 12 Mar 2002 01:51:42 +0100 (MET)	[thread overview]
Message-ID: <200203120051.BAA20236@harpo.it.uu.se> (raw)

Marcelo wrote in the 2.4.19-pre3 announcement:
>pre3:
>- Fix off-by-one error in bluesmoke			(Dave Jones)

NO NO NO! This is the same broken patch that somehow got into
2.2.21pre4 as well. The patch changes the code to write to the
IA32_MC0_CTL MSR, which is a big no-no. Intel's IA32 Vol3 manual
(#245472-03) sections 13.3.2.1 and 13.5 make that point quite clear.

I have several P6 boxes that hang hard in MCE init trying to boot
vanilla 2.2.21pre4 and 2.4.19-pre3. The issue is real.

Please apply the backup patch below.

/Mikael

--- linux-2.4.19-pre3/arch/i386/kernel/bluesmoke.c.~1~	Tue Mar 12 00:25:53 2002
+++ linux-2.4.19-pre3/arch/i386/kernel/bluesmoke.c	Tue Mar 12 01:11:58 2002
@@ -169,7 +169,7 @@
 	if(l&(1<<8))
 		wrmsr(MSR_IA32_MCG_CTL, 0xffffffff, 0xffffffff);
 	banks = l&0xff;
-	for(i=0;i<banks;i++)
+	for(i=1;i<banks;i++)
 	{
 		wrmsr(MSR_IA32_MC0_CTL+4*i, 0xffffffff, 0xffffffff);
 	}

             reply	other threads:[~2002-03-12  0:52 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-03-12  0:51 Mikael Pettersson [this message]
2002-03-12  5:13 ` Linux 2.4.19-pre3 skidley
2002-03-12 21:00 ` Dave Jones
     [not found] <fa.npg7nmv.si46bq@ifi.uio.no>
2002-03-12  7:26 ` junkio
  -- strict thread matches above, loose matches on Subject: below --
2002-03-11 21:08 Marcelo Tosatti
2002-03-11 22:40 ` Eyal Lebedinsky
2002-03-11 23:03   ` Alan Cox
2002-03-11 22:55 ` Stephan von Krawczynski
2002-03-12  1:50   ` Mike Fedyk
2002-03-12 11:06   ` Stephan von Krawczynski
2002-03-11 23:04 ` Eyal Lebedinsky
2002-03-11 23:14   ` Keith Owens
2002-03-12 15:49   ` DevilKin
2002-03-11 23:21 ` Eyal Lebedinsky
2002-03-12  1:40   ` Takeo Saito
2002-03-12  0:04 ` J.A. Magallon
2002-03-12  0:37 ` Ken Brownfield
2002-03-12 10:35 ` Gerd Knorr
2002-03-12 17:24   ` Trond Myklebust
2002-03-12 17:47   ` Gerd Knorr
2002-03-12 13:01 ` Karsten Weiss
2002-03-12 13:17   ` Jens Axboe
2002-03-12 13:37   ` Alan Cox
2002-03-12 13:46   ` Jens Axboe
2002-03-12 19:02     ` Marcelo Tosatti
2002-03-13  8:09       ` Jens Axboe
2002-03-13  9:00         ` Andre Hedrick
2002-03-13  9:27           ` Jens Axboe
2002-03-13  9:33             ` Andre Hedrick
2002-03-13 17:32               ` Andre Hedrick
2002-03-13 17:40                 ` Jens Axboe
2002-03-13 18:52                   ` Andre Hedrick
2002-03-14  4:41           ` Marcelo Tosatti
2002-03-14  6:28             ` Andre Hedrick
2002-03-14  3:32         ` Michal Jaegermann
2002-03-12 14:47   ` J.A. Magallon
2002-03-12 13:31 ` Jurgen Philippaerts
2002-03-12 15:43 ` Geert Uytterhoeven
2002-03-12 21:59 ` Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200203120051.BAA20236@harpo.it.uu.se \
    --to=mikpe@csd.uu.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).