Re: Linux 2.4.19-pre3

[Marcelo Tosatti <marcelo@conectiva.com.br>]

On Tue, 12 Mar 2002, Jens Axboe wrote:

> On Tue, Mar 12 2002, Karsten Weiss wrote:
> > > Here goes -pre3, with the new IDE code. It has been stable enough time in
> 
> Oh good god, the nr_sectors/current_nr_sectors for the pio data phases
> haven't been fixed _yet_?!
> 
> task_in_intr()
> {
> 	...
> 	pBuf = rq->buffer + ((rq->nr_sectors - rq->current_nr_sectors) * SECTOR_SIZE);
> }
> 
> And that's just one instance. Good luck running 2.4.19-pre3, this is
> just so badly broken I can't find words to explain it (again). It's
> really puzzling why this is still broken. I fixed it in 2.5 when the
> merge happened there, the issue has been known for at least that long. I
> can only recommend that no one uses 2.4.19-pre3!
> 
> Marcelo, at least apply the noop patch here. If I get motivated I'll fix
> the interrupt handlers as well, can't say I really want to though...

As I previously said, I will apply the noop patch.

I've read the flamewar which this mail generated, but I prefer to simply
ignore that: Its useless for me, it haven't explained me nothing which
matters (that is, the technical side of the problem Jens described).

So, Jens, could you please explain the problem in the interrupt handlers
in detail ?