* xosview
@ 2002-06-05 19:32 Klaus Dittrich
0 siblings, 0 replies; 7+ messages in thread
From: Klaus Dittrich @ 2002-06-05 19:32 UTC (permalink / raw)
To: linux mailing-list
I applied the patch from Andrew and xosview (1.8) works now.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: xosview
2002-06-05 7:40 ` xosview kwijibo
@ 2002-06-05 7:55 ` Andrew Morton
0 siblings, 0 replies; 7+ messages in thread
From: Andrew Morton @ 2002-06-05 7:55 UTC (permalink / raw)
To: kwijibo; +Cc: Klaus Dittrich, linux-kernel
kwijibo@zianet.com wrote:
>
> I believe it is xosview that needs to change and not
> the kernel. Mine worked with pre8 however, my move
> to pre10 broke it.
>
It's the gunk in /proc/stat which broke it. Some
accidentally-included debug stuff.
--- linux-2.4.19-pre9/fs/proc/proc_misc.c Tue May 28 17:23:37 2002
+++ linux-mnm/fs/proc/proc_misc.c Tue Jun 4 23:25:12 2002
@@ -322,7 +322,7 @@ static int kstat_read_proc(char *page, c
#if !defined(CONFIG_ARCH_S390)
for (i = 0 ; i < NR_IRQS ; i++)
proc_sprintf(page, &off, &len,
- " %u", kstat_irqs(i) + 1000000000);
+ " %u", kstat_irqs(i));
#endif
proc_sprintf(page, &off, &len, "\ndisk_io: ");
-
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: xosview
2002-06-05 6:07 xosview Klaus Dittrich
` (2 preceding siblings ...)
2002-06-05 7:52 ` xosview Kristian Peters
@ 2002-06-05 7:53 ` Jochen Krieb
3 siblings, 0 replies; 7+ messages in thread
From: Jochen Krieb @ 2002-06-05 7:53 UTC (permalink / raw)
To: linux-kernel
Works fine here.
(2.4.18 & 2.4.19-pre10)
On Wed, 5 Jun 2002 08:07:02 +0200
kladit@t-online.de (Klaus Dittrich) wrote:
> Since 2.4.18p8 xosview does not work anymore.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: xosview
2002-06-05 6:07 xosview Klaus Dittrich
2002-06-05 7:29 ` xosview J Sloan
2002-06-05 7:40 ` xosview kwijibo
@ 2002-06-05 7:52 ` Kristian Peters
2002-06-05 7:53 ` xosview Jochen Krieb
3 siblings, 0 replies; 7+ messages in thread
From: Kristian Peters @ 2002-06-05 7:52 UTC (permalink / raw)
To: Klaus Dittrich; +Cc: linux-kernel
kladit@t-online.de (Klaus Dittrich) wrote:
> Since 2.4.18p8 xosview does not work anymore.
That's a known problem. xosview tries to access /proc/stat that has a wierd format and a buffer goes beyond 1024 in xosview. I was also effected on this problem. It's been fixed in the next version of 2.4.19 (probably -rc1). In the meantime you can apply this patch:
diff -ur linux-2.4.19-pre9.org/fs/proc/proc_misc.c linux-2.4.19-pre9/fs/proc/proc_misc.c
--- linux-2.4.19-pre9.org/fs/proc/proc_misc.c Wed May 29 01:26:17 2002
+++ linux-2.4.19-pre9/fs/proc/proc_misc.c Thu May 30 03:09:07 2002
@@ -322,7 +322,7 @@
#if !defined(CONFIG_ARCH_S390)
for (i = 0 ; i < NR_IRQS ; i++)
proc_sprintf(page, &off, &len,
- " %u", kstat_irqs(i) + 1000000000);
+ " %u", kstat_irqs(i));
#endif
proc_sprintf(page, &off, &len, "\ndisk_io: ");
*Kristian
:... [snd.science] ...:
:: _o)
:: http://www.korseby.net /\\
:: http://gsmp.sf.net _\_V
:.........................:
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: xosview
2002-06-05 6:07 xosview Klaus Dittrich
2002-06-05 7:29 ` xosview J Sloan
@ 2002-06-05 7:40 ` kwijibo
2002-06-05 7:55 ` xosview Andrew Morton
2002-06-05 7:52 ` xosview Kristian Peters
2002-06-05 7:53 ` xosview Jochen Krieb
3 siblings, 1 reply; 7+ messages in thread
From: kwijibo @ 2002-06-05 7:40 UTC (permalink / raw)
To: Klaus Dittrich; +Cc: linux-kernel
I believe it is xosview that needs to change and not
the kernel. Mine worked with pre8 however, my move
to pre10 broke it.
Steve
Klaus Dittrich wrote:
>Since 2.4.18p8 xosview does not work anymore.
>-
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/
>
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: xosview
2002-06-05 6:07 xosview Klaus Dittrich
@ 2002-06-05 7:29 ` J Sloan
2002-06-05 7:40 ` xosview kwijibo
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: J Sloan @ 2002-06-05 7:29 UTC (permalink / raw)
To: Klaus Dittrich; +Cc: linux-kernel
hmm -
It's working fine here on my 2 systems running
2.4.19-pre9aa2 and RH 7.3 kernel (2.4.18-4) -
Joe
Klaus Dittrich wrote:
>Since 2.4.18p8 xosview does not work anymore.
>-
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* xosview
@ 2002-06-05 6:07 Klaus Dittrich
2002-06-05 7:29 ` xosview J Sloan
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Klaus Dittrich @ 2002-06-05 6:07 UTC (permalink / raw)
To: linux-kernel
Since 2.4.18p8 xosview does not work anymore.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2002-06-05 19:42 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-06-05 19:32 xosview Klaus Dittrich
-- strict thread matches above, loose matches on Subject: below --
2002-06-05 6:07 xosview Klaus Dittrich
2002-06-05 7:29 ` xosview J Sloan
2002-06-05 7:40 ` xosview kwijibo
2002-06-05 7:55 ` xosview Andrew Morton
2002-06-05 7:52 ` xosview Kristian Peters
2002-06-05 7:53 ` xosview Jochen Krieb
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).