* [PATCH] Allow mpage.c to build
@ 2002-06-05 15:05 Russell King
2002-06-05 19:49 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Russell King @ 2002-06-05 15:05 UTC (permalink / raw)
To: Linus Torvalds, Linux Kernel List
Linus,
When trying to build mpage.c for ARM, I get errors from bio.h since kdev_t
isn't defined. The following fixes this.
(I fail to see how this can build for anyone as it currently stands; its
probably something x86 specific buried in the asm-i386 includes.)
--- orig/fs/mpage.c Wed May 29 23:57:08 2002
+++ linux/fs/mpage.c Thu May 30 00:34:44 2002
@@ -12,6 +12,7 @@
#include <linux/kernel.h>
#include <linux/module.h>
+#include <linux/kdev_t.h>
#include <linux/bio.h>
#include <linux/fs.h>
#include <linux/buffer_head.h>
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Allow mpage.c to build
2002-06-05 15:05 [PATCH] Allow mpage.c to build Russell King
@ 2002-06-05 19:49 ` Andrew Morton
2002-06-05 19:59 ` Dave Jones
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2002-06-05 19:49 UTC (permalink / raw)
To: Russell King; +Cc: Linux Kernel List
Russell King wrote:
>
> Linus,
>
> When trying to build mpage.c for ARM, I get errors from bio.h since kdev_t
> isn't defined. The following fixes this.
>
> (I fail to see how this can build for anyone as it currently stands; its
> probably something x86 specific buried in the asm-i386 includes.)
>
> ...
/usr/src/25/include/linux/bio.h
/usr/src/25/include/asm/io.h
/usr/src/25/include/linux/vmalloc.h
/usr/src/25/include/linux/mm.h
/usr/src/25/include/linux/swap.h
/usr/src/25/include/linux/kdev_t.h
Lovely, isn't it?
-
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Allow mpage.c to build
2002-06-05 19:49 ` Andrew Morton
@ 2002-06-05 19:59 ` Dave Jones
0 siblings, 0 replies; 3+ messages in thread
From: Dave Jones @ 2002-06-05 19:59 UTC (permalink / raw)
To: Andrew Morton; +Cc: Russell King, Linux Kernel List
On Wed, Jun 05, 2002 at 12:49:05PM -0700, Andrew Morton wrote:
> /usr/src/25/include/linux/bio.h
> /usr/src/25/include/asm/io.h
> /usr/src/25/include/linux/vmalloc.h
> /usr/src/25/include/linux/mm.h
^^^^^
This bugger should be high on the list of include files that need
feeding through the include-chopper-upper.
> /usr/src/25/include/linux/swap.h
> /usr/src/25/include/linux/kdev_t.h
> Lovely, isn't it?
Wouldn't be so bad if it were an isolated case..
Hopefully by the time we get to 2.6, a lot of this
'include by implication' nonsense can be cleaned up some more.
Dave.
--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2002-06-05 19:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-06-05 15:05 [PATCH] Allow mpage.c to build Russell King
2002-06-05 19:49 ` Andrew Morton
2002-06-05 19:59 ` Dave Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).