* input u-cleanup
@ 2002-08-28 22:06 Pavel Machek
2002-08-29 6:17 ` Vojtech Pavlik
0 siblings, 1 reply; 4+ messages in thread
From: Pavel Machek @ 2002-08-28 22:06 UTC (permalink / raw)
To: kernel list, vojtech
Hi!
proc is clever enough not to need ifdefs, so this is probably good
idea...
Pavel
--- clean/drivers/input/input.c Wed Aug 28 22:38:46 2002
+++ linux-swsusp/drivers/input/input.c Wed Aug 28 23:28:23 2002
@@ -800,11 +803,9 @@
static void __exit input_exit(void)
{
-#ifdef CONFIG_PROC_FS
remove_proc_entry("devices", proc_bus_input_dir);
remove_proc_entry("handlers", proc_bus_input_dir);
remove_proc_entry("input", proc_bus);
-#endif
devfs_unregister(input_devfs_handle);
if (unregister_chrdev(INPUT_MAJOR, "input"))
printk(KERN_ERR "input: can't unregister char major %d", INPUT_MAJOR);
--
Worst form of spam? Adding advertisment signatures ala sourceforge.net.
What goes next? Inserting advertisment *into* email?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: input u-cleanup
2002-08-28 22:06 input u-cleanup Pavel Machek
@ 2002-08-29 6:17 ` Vojtech Pavlik
2002-08-29 22:26 ` Pavel Machek
0 siblings, 1 reply; 4+ messages in thread
From: Vojtech Pavlik @ 2002-08-29 6:17 UTC (permalink / raw)
To: Pavel Machek; +Cc: kernel list
On Thu, Aug 29, 2002 at 12:06:03AM +0200, Pavel Machek wrote:
> Hi!
>
> proc is clever enough not to need ifdefs, so this is probably good
> idea...
>
> Pavel
If you could remove all the procfs #ifdefs from input.c, that'd be great.
But removing only those around unregistration IMHO doesn't make sense.
>
> --- clean/drivers/input/input.c Wed Aug 28 22:38:46 2002
> +++ linux-swsusp/drivers/input/input.c Wed Aug 28 23:28:23 2002
> @@ -800,11 +803,9 @@
>
> static void __exit input_exit(void)
> {
> -#ifdef CONFIG_PROC_FS
> remove_proc_entry("devices", proc_bus_input_dir);
> remove_proc_entry("handlers", proc_bus_input_dir);
> remove_proc_entry("input", proc_bus);
> -#endif
> devfs_unregister(input_devfs_handle);
> if (unregister_chrdev(INPUT_MAJOR, "input"))
> printk(KERN_ERR "input: can't unregister char major %d", INPUT_MAJOR);
>
> --
> Worst form of spam? Adding advertisment signatures ala sourceforge.net.
> What goes next? Inserting advertisment *into* email?
--
Vojtech Pavlik
SuSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: input u-cleanup
2002-08-29 6:17 ` Vojtech Pavlik
@ 2002-08-29 22:26 ` Pavel Machek
2002-08-30 5:37 ` Vojtech Pavlik
0 siblings, 1 reply; 4+ messages in thread
From: Pavel Machek @ 2002-08-29 22:26 UTC (permalink / raw)
To: Vojtech Pavlik; +Cc: Pavel Machek, kernel list
Hi!
> > proc is clever enough not to need ifdefs, so this is probably good
> > idea...
> >
> > Pavel
>
> If you could remove all the procfs #ifdefs from input.c, that'd be great.
> But removing only those around unregistration IMHO doesn't make
> > sense.
They can be safely dropped. I had patch to do that but droped it during
merge. If you'll accept complete patch, I'll create it. [Or you can
do it yourself, just killing #ifdef CONFIG_PROC_FS should do the
trick].
> >
> > --- clean/drivers/input/input.c Wed Aug 28 22:38:46 2002
> > +++ linux-swsusp/drivers/input/input.c Wed Aug 28 23:28:23 2002
> > @@ -800,11 +803,9 @@
> >
> > static void __exit input_exit(void)
> > {
> > -#ifdef CONFIG_PROC_FS
> > remove_proc_entry("devices", proc_bus_input_dir);
> > remove_proc_entry("handlers", proc_bus_input_dir);
> > remove_proc_entry("input", proc_bus);
> > -#endif
> > devfs_unregister(input_devfs_handle);
> > if (unregister_chrdev(INPUT_MAJOR, "input"))
> > printk(KERN_ERR "input: can't unregister char major %d", INPUT_MAJOR);
> >
> > --
> > Worst form of spam? Adding advertisment signatures ala sourceforge.net.
> > What goes next? Inserting advertisment *into* email?
>
--
Casualities in World Trade Center: ~3k dead inside the building,
cryptography in U.S.A. and free speech in Czech Republic.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: input u-cleanup
2002-08-29 22:26 ` Pavel Machek
@ 2002-08-30 5:37 ` Vojtech Pavlik
0 siblings, 0 replies; 4+ messages in thread
From: Vojtech Pavlik @ 2002-08-30 5:37 UTC (permalink / raw)
To: Pavel Machek; +Cc: Vojtech Pavlik, Pavel Machek, kernel list
On Fri, Aug 30, 2002 at 12:26:42AM +0200, Pavel Machek wrote:
> > > proc is clever enough not to need ifdefs, so this is probably good
> > > idea...
> > >
> > > Pavel
> >
> > If you could remove all the procfs #ifdefs from input.c, that'd be great.
> > But removing only those around unregistration IMHO doesn't make
> > > sense.
>
>
> They can be safely dropped. I had patch to do that but droped it during
> merge. If you'll accept complete patch, I'll create it. [Or you can
> do it yourself, just killing #ifdef CONFIG_PROC_FS should do the
> trick].
Yes, but a lot of functions unneeded without CONFIG_PROC_FS will remain
linked in ... if you manage it down to one #ifdef, just around the
functions, I'll take it.
--
Vojtech Pavlik
SuSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2002-08-30 5:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-08-28 22:06 input u-cleanup Pavel Machek
2002-08-29 6:17 ` Vojtech Pavlik
2002-08-29 22:26 ` Pavel Machek
2002-08-30 5:37 ` Vojtech Pavlik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).