[PATCH] Module rewrite 6/20: streq

[PATCH] Module rewrite 6/20: streq

[Rusty Russell]

Name: streq implementation
Author: Rusty Russell
Status: Trivial
Depends: Misc/strcspn.patch.gz

D: I can't believe that after all these years I still make the "sense
D: of strcmp" mistake.  So it's time to reintroduce my favorite macro.

diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal .24879-linux-2.5.38/include/linux/string.h .24879-linux-2.5.38.updated/include/linux/string.h
--- .24879-linux-2.5.38/include/linux/string.h	2002-09-24 21:23:55.000000000 +1000
+++ .24879-linux-2.5.38.updated/include/linux/string.h	2002-09-24 21:24:33.000000000 +1000
@@ -16,6 +16,7 @@ extern char * strpbrk(const char *,const
 extern char * strsep(char **,const char *);
 extern __kernel_size_t strspn(const char *,const char *);
 extern __kernel_size_t strcspn(const char *,const char *);
+#define streq(a,b) (strcmp((a),(b)) == 0)
 
 /*
  * Include machine specific inline routines

--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

Re: [PATCH] Module rewrite 6/20: streq

[Alan Cox]

On Wed, 2002-09-25 at 04:01, Rusty Russell wrote:
> Name: streq implementation
> Author: Rusty Russell
> Status: Trivial
> Depends: Misc/strcspn.patch.gz
> 
> D: I can't believe that after all these years I still make the "sense
> D: of strcmp" mistake.  So it's time to reintroduce my favorite macro.

So you replace something all the competent programmers understand with
some weird Rusty specific macro that just makes it harder still for
other people to follow kernel code.

Why ?