* [Patch 1/7] 2.4.20-pre4/ext3: Fix LVM snapshot deadlock
@ 2002-09-26 13:55 Stephen Tweedie
0 siblings, 0 replies; only message in thread
From: Stephen Tweedie @ 2002-09-26 13:55 UTC (permalink / raw)
To: Marcelo Tosatti, linux-kernel; +Cc: Stephen Tweedie
Fix LVM snapshot deadlock: it is a bad idea to try to flush all running
transactions while we already hold the superblock lock. Drop the sb lock
while we flush.
This only affects kernels that have the extra LVM VFS locking added in
for filesystem quiescing on snapshots.
--- linux-2.4-ext3merge/fs/ext3/super.c.=K0000=.orig Thu Sep 26 12:19:14 2002
+++ linux-2.4-ext3merge/fs/ext3/super.c Thu Sep 26 12:25:37 2002
@@ -1588,8 +1588,10 @@
journal_t *journal = EXT3_SB(sb)->s_journal;
/* Now we set up the journal barrier. */
+ unlock_super(sb);
journal_lock_updates(journal);
journal_flush(journal);
+ lock_super(sb);
/* Journal blocked and flushed, clear needs_recovery flag. */
EXT3_CLEAR_INCOMPAT_FEATURE(sb, EXT3_FEATURE_INCOMPAT_RECOVER);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2002-09-26 13:51 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-09-26 13:55 [Patch 1/7] 2.4.20-pre4/ext3: Fix LVM snapshot deadlock Stephen Tweedie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).