From: Hu Gang <gang_hu@soul.com.cn>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [patch] Serial 2/2
Date: Sun, 29 Sep 2002 12:17:59 +0800 [thread overview]
Message-ID: <20020929121759.51685230.gang_hu@soul.com.cn> (raw)
[-- Attachment #1: Type: text/plain, Size: 878 bytes --]
Hello all:
fix ret check bug: 2.5.39
--- drivers/serial/8250.c~old Sun Sep 29 12:06:03 2002
+++ drivers/serial/8250.c Sun Sep 29 12:17:05 2002
@@ -1564,7 +1565,7 @@
if (up->port.type == PORT_RSA) {
ret = serial8250_request_rsa_resource(up, &res_rsa);
- if (ret)
+ if (ret == 0)
return ret;
}
@@ -1582,10 +1583,10 @@
ret = -ENOMEM;
}
- if (ret) {
- if (res_rsa)
+ if (ret == 0) {
+ if (res_rsa == 0)
release_resource(res_rsa);
- if (res)
+ if (res == 0)
release_resource(res);
}
return ret;
@@ -1611,11 +1612,11 @@
* tells us whether we can probe for the type of port.
*/
ret = serial8250_request_std_resource(up, &res_std);
- if (ret)
+ if (ret == 0)
return;
ret = serial8250_request_rsa_resource(up, &res_rsa);
- if (ret)
+ if (ret == 0)
probeflags &= ~PROBE_RSA;
if (flags & UART_CONFIG_TYPE)
--
- Hu Gang
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next reply other threads:[~2002-09-29 4:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-29 4:17 Hu Gang [this message]
2002-09-29 16:11 [patch] Serial 2/2 Matthew Wilcox
2002-09-29 17:27 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020929121759.51685230.gang_hu@soul.com.cn \
--to=gang_hu@soul.com.cn \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).