* [PATCH] vmalloc.c patch for 2.4.20-pre8-ac3
@ 2002-10-01 0:44 Art Haas
2002-10-01 15:24 ` Dave Jones
0 siblings, 1 reply; 2+ messages in thread
From: Art Haas @ 2002-10-01 0:44 UTC (permalink / raw)
To: linux-kernel
Hi.
It looks like the small vmalloc.c patch didn't make it into
2.4.20-pre8-ac3. The patch is needed because the wrong variable
is passed to kfree().
Art Haas
--- linux-2.4.20-pre8-ac3/mm/vmalloc.c.ac3 2002-09-30 18:27:42.000000000 -0500
+++ linux-2.4.20-pre8-ac3/mm/vmalloc.c 2002-09-30 13:59:30.000000000 -0500
@@ -179,7 +179,7 @@
size += PAGE_SIZE;
if (!size) {
- kfree (addr);
+ kfree (area);
return NULL;
}
--
They that can give up essential liberty to obtain a little temporary safety
deserve neither liberty nor safety.
-- Benjamin Franklin, Historical Review of Pennsylvania, 1759
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] vmalloc.c patch for 2.4.20-pre8-ac3
2002-10-01 0:44 [PATCH] vmalloc.c patch for 2.4.20-pre8-ac3 Art Haas
@ 2002-10-01 15:24 ` Dave Jones
0 siblings, 0 replies; 2+ messages in thread
From: Dave Jones @ 2002-10-01 15:24 UTC (permalink / raw)
To: Art Haas; +Cc: linux-kernel
On Mon, Sep 30, 2002 at 07:44:32PM -0500, Art Haas wrote:
> --- linux-2.4.20-pre8-ac3/mm/vmalloc.c.ac3 2002-09-30 18:27:42.000000000 -0500
> +++ linux-2.4.20-pre8-ac3/mm/vmalloc.c 2002-09-30 13:59:30.000000000 -0500
> @@ -179,7 +179,7 @@
>
> size += PAGE_SIZE;
> if (!size) {
> - kfree (addr);
> + kfree (area);
> return NULL;
> }
Ick, that's my bad. Fix is correct, though davem suggested testing
for -PAGE_SIZE before we do the kmalloc would be cleaner.
I tend to agree, but didn't get around to doing it.
Dave
--
| Dave Jones. http://www.codemonkey.org.uk
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-10-01 15:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-10-01 0:44 [PATCH] vmalloc.c patch for 2.4.20-pre8-ac3 Art Haas
2002-10-01 15:24 ` Dave Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).