* Re: a problem report
@ 2002-10-02 18:49 Peter Samuelson
2002-10-02 19:36 ` Sam Ravnborg
0 siblings, 1 reply; 5+ messages in thread
From: Peter Samuelson @ 2002-10-02 18:49 UTC (permalink / raw)
To: linux-kernel
[Sam Ravnborg]
> --- linux/sound/Config.in 2002-10-01 12:09:44.000000000 +0200
> +++ linux/sound/Config.in 2002-10-01 12:21:05.000000000 +0200
> @@ -31,10 +31,7 @@
> if [ "$CONFIG_SND" != "n" -a "$CONFIG_ARM" = "y" ]; then
> source sound/arm/Config.in
> fi
> -if [ "$CONFIG_SND" != "n" -a "$CONFIG_SPARC32" = "y" ]; then
> - source sound/sparc/Config.in
> -fi
> -if [ "$CONFIG_SND" != "n" -a "$CONFIG_SPARC64" = "y" ]; then
> +if [ "$CONFIG_SND" != "n" -a "$CONFIG_SPARC32" = "y" ] || [ "$CONFIG_SND" != "n" -a "$CONFIG_SPARC64" = "y" ] ; then
> source sound/sparc/Config.in
> fi
That's not right. You can't use '||' in config language. (Try it
with xconfig some time.) You have to either nest if statements or
make use of precedence. Documentation/kbuild/config-language.txt
doesn't actually specify the precedence, but in the Unix test(1) from
which it is derived, AND binds tighter than OR. Thus:
if [ "$CONFIG_SND" != "n" ]; then
if [ "$CONFIG_SPARC32" = "y" -o "$CONFIG_SPARC64" = "y" ]; then
source sound/sparc/Config.in
fi
fi
-- or --
if [ "$CONFIG_SND" != "n" -a "$CONFIG_SPARC32" = "y" -o \
"$CONFIG_SND" != "n" -a "$CONFIG_SPARC64" = "y" ]; then
source sound/sparc/Config.in
fi
This 'if' statement syntax has *got* to go. I posted an incomplete
replacement syntax some time ago, but abandoned it because it appeared
Roman was almost ready to merge his new config stuff....
Peter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: a problem report
2002-10-02 18:49 a problem report Peter Samuelson
@ 2002-10-02 19:36 ` Sam Ravnborg
2002-10-02 20:13 ` Roman Zippel
0 siblings, 1 reply; 5+ messages in thread
From: Sam Ravnborg @ 2002-10-02 19:36 UTC (permalink / raw)
To: Peter Samuelson; +Cc: linux-kernel
On Wed, Oct 02, 2002 at 01:49:11PM -0500, Peter Samuelson wrote:
> [Sam Ravnborg]
[Snip faulty Config.in patch]
> That's not right. You can't use '||' in config language. (Try it
> with xconfig some time.)
I was aware of this, the only reason why I posted this was to let people
proceed with menuconfig, and to give them a response.
Roman Zippel already posted a correct path, that he also has sent to Linus.
Although I do not understand where the ALSA people are in this game.
> This 'if' statement syntax has *got* to go. I posted an incomplete
> replacement syntax some time ago, but abandoned it because it appeared
> Roman was almost ready to merge his new config stuff....
The 2.5.39 version of Roman's lkc looked really good IMHO, but I think
more people has to get into the discussion before it will be accepted.
I for one is not the right person to comment on the config
language, old or new.
Sam
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: a problem report
2002-10-02 19:36 ` Sam Ravnborg
@ 2002-10-02 20:13 ` Roman Zippel
0 siblings, 0 replies; 5+ messages in thread
From: Roman Zippel @ 2002-10-02 20:13 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: Peter Samuelson, linux-kernel
Hi,
On Wed, 2 Oct 2002, Sam Ravnborg wrote:
> The 2.5.39 version of Roman's lkc looked really good IMHO, but I think
> more people has to get into the discussion before it will be accepted.
I'd be happy about a discussion, but if it's not happening soon, it's up
to Linus to accept it.
bye, Roman
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: a problem report
2002-10-02 12:06 ken hu
@ 2002-10-02 12:49 ` Sam Ravnborg
0 siblings, 0 replies; 5+ messages in thread
From: Sam Ravnborg @ 2002-10-02 12:49 UTC (permalink / raw)
To: ken hu; +Cc: mec, linux-kernel
On Wed, Oct 02, 2002 at 05:06:47AM -0700, ken hu wrote:
> Menuconfig has encountered a possible error in one of
> the kernel's
Thanks, known problem.
Try this patch:
copy-n-pated so may not apply cleanly, try by hand.
Sam
--- linux/sound/Config.in 2002-10-01 12:09:44.000000000 +0200
+++ linux/sound/Config.in 2002-10-01 12:21:05.000000000 +0200
@@ -31,10 +31,7 @@
if [ "$CONFIG_SND" != "n" -a "$CONFIG_ARM" = "y" ]; then
source sound/arm/Config.in
fi
-if [ "$CONFIG_SND" != "n" -a "$CONFIG_SPARC32" = "y" ]; then
- source sound/sparc/Config.in
-fi
-if [ "$CONFIG_SND" != "n" -a "$CONFIG_SPARC64" = "y" ]; then
+if [ "$CONFIG_SND" != "n" -a "$CONFIG_SPARC32" = "y" ] || [ "$CONFIG_SND" !=
"n" -a "$CONFIG_SPARC64" = "y" ] ; then
source sound/sparc/Config.in
fi
^ permalink raw reply [flat|nested] 5+ messages in thread
* a problem report
@ 2002-10-02 12:06 ken hu
2002-10-02 12:49 ` Sam Ravnborg
0 siblings, 1 reply; 5+ messages in thread
From: ken hu @ 2002-10-02 12:06 UTC (permalink / raw)
To: mec; +Cc: linux-kernel
Menuconfig has encountered a possible error in one of
the kernel's
configuration files and is unable to continue. Here
is the error
report:
Q> ./scripts/Menuconfig: line 823: MCmenu74: command
not found
Please report this to the maintainer <mec@shout.net>.
You may also
send a problem report to
<linux-kernel@vger.kernel.org>.
Please indicate the kernel version you are trying to
configure and
which menu you were trying to enter when this error
occurred.
make: *** [menuconfig] Error 1
Advanced Linux Sound Architecture menu i was trying
to enter when this error occurred.
kernel version is 2.5.40
__________________________________________________
Do you Yahoo!?
New DSL Internet Access from SBC & Yahoo!
http://sbc.yahoo.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2002-10-02 20:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-10-02 18:49 a problem report Peter Samuelson
2002-10-02 19:36 ` Sam Ravnborg
2002-10-02 20:13 ` Roman Zippel
-- strict thread matches above, loose matches on Subject: below --
2002-10-02 12:06 ken hu
2002-10-02 12:49 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).