* [PATCH] [TRIVIAL] 2.5.40 de2104x: a lots of timer messages @ 2002-10-04 16:50 Denis Zaitsev 2002-10-04 19:54 ` Jeff Garzik 0 siblings, 1 reply; 3+ messages in thread From: Denis Zaitsev @ 2002-10-04 16:50 UTC (permalink / raw) To: davej; +Cc: linux-kernel This patch fixes a lots of annoying timer messages for this ethernet adapter. Please, apply it. --- drivers/net/tulip/de2104x.c.orig Sun Aug 18 02:56:40 2002 +++ drivers/net/tulip/de2104x.c Fri Oct 4 00:18:02 2002 @@ -77,7 +77,6 @@ #define DE_DEF_MSG_ENABLE (NETIF_MSG_DRV | \ NETIF_MSG_PROBE | \ NETIF_MSG_LINK | \ - NETIF_MSG_TIMER | \ NETIF_MSG_IFDOWN | \ NETIF_MSG_IFUP | \ NETIF_MSG_RX_ERR | \ ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [TRIVIAL] 2.5.40 de2104x: a lots of timer messages 2002-10-04 16:50 [PATCH] [TRIVIAL] 2.5.40 de2104x: a lots of timer messages Denis Zaitsev @ 2002-10-04 19:54 ` Jeff Garzik 2002-10-05 15:30 ` Denis Zaitsev 0 siblings, 1 reply; 3+ messages in thread From: Jeff Garzik @ 2002-10-04 19:54 UTC (permalink / raw) To: Denis Zaitsev; +Cc: davej, linux-kernel Denis Zaitsev wrote: > This patch fixes a lots of annoying timer messages for this ethernet > adapter. Please, apply it. If the messages annoy you, disable that bit using ethtool. It's not necessary to hack the driver for this. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [TRIVIAL] 2.5.40 de2104x: a lots of timer messages 2002-10-04 19:54 ` Jeff Garzik @ 2002-10-05 15:30 ` Denis Zaitsev 0 siblings, 0 replies; 3+ messages in thread From: Denis Zaitsev @ 2002-10-05 15:30 UTC (permalink / raw) To: Jeff Garzik; +Cc: linux-kernel On Fri, Oct 04, 2002 at 03:54:19PM -0400, Jeff Garzik wrote: > Denis Zaitsev wrote: > > This patch fixes a lots of annoying timer messages for this ethernet > > adapter. Please, apply it. > > > If the messages annoy you, disable that bit using ethtool. It's not > necessary to hack the driver for this. > It's hard to really call that a "hack"... And do you want to say that you won't be annoyed, if each minute you have on your console the message: eth0: 10baseT auto link ok, mode 7ffc2002 status 51c8 I.e. 1440 of the same messages per day... So, will you? Or another approach: the only one of all the other drivers/net use NETIF_MSG_TIMER included into xxx_DEF_MSG_ENABLE, and this one is Tigon3 driver, which is, again, your. And no one else. And this silence seems to be a some kind of a "normal" behaviour, doesn't it? And no one of other drivers needs ethtool to be just silent... Or, may be there are some reasons for such a verbosing, I just don't know about? And, important: of course, I had to send the patch to you. I'm sorry, for some reason I decided that the driver is unmaintained for the some time. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2002-10-05 15:25 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2002-10-04 16:50 [PATCH] [TRIVIAL] 2.5.40 de2104x: a lots of timer messages Denis Zaitsev 2002-10-04 19:54 ` Jeff Garzik 2002-10-05 15:30 ` Denis Zaitsev
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).