Re: [patch] kmalloc_percpu

From: Dipankar Sarma <dipankar@gamebox.net>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Ravikiran G Thirumalai <kiran@in.ibm.com>,
	akpm@zip.com.au, linux-kernel@vger.kernel.org
Subject: Re: [patch] kmalloc_percpu
Date: Tue, 5 Nov 2002 21:30:46 +0530	[thread overview]
Message-ID: <20021105213046.B10886@dikhow> (raw)
In-Reply-To: <20021101193354.54367ba4.rusty@rustcorp.com.au>; from rusty@rustcorp.com.au on Fri, Nov 01, 2002 at 07:33:54PM +1100

On Fri, Nov 01, 2002 at 07:33:54PM +1100, Rusty Russell wrote:
> On Thu, 31 Oct 2002 21:36:40 +0530
> Ravikiran G Thirumalai <kiran@in.ibm.com> wrote:
> 
> > Here's  kmalloc_percpu interfaces ported (...mostly rediffed) to 
> > 2.5.45.  (One last try for 2.6).
> 
> IMHO this is a "when we need it" patch.  Baby steps...

Agreed. It could be useful if we want to use per-CPU statistics
for things like disk I/O (now in struct gendisk).

> 
> > +#define this_cpu_ptr(ptr) per_cpu_ptr(ptr, smp_processor_id())
> 
> Probably want a get_cpu_ptr() & put_cpu_ptr() using get_cpu() and put_cpu()
> (and this would become __get_cpu_ptr()).
> 
> And probably move them all to linux/percpu.h.

Yes, it needs to sync up with its static twin ;-)

Thanks
Dipankar