* [TRIVIAL PATCH 2.5.47] Remove compile warning from scsi/scsi.c
@ 2002-11-13 22:27 Bob Miller
2002-12-02 3:57 ` Rusty Russell
0 siblings, 1 reply; 2+ messages in thread
From: Bob Miller @ 2002-11-13 22:27 UTC (permalink / raw)
To: trivial; +Cc: linux-kernel
diff -Nru a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c
--- a/drivers/scsi/scsi.c Wed Nov 13 14:09:57 2002
+++ b/drivers/scsi/scsi.c Wed Nov 13 14:09:57 2002
@@ -1985,7 +1985,7 @@
up_read(&scsi_devicelist_mutex);
return 0;
-fail:
+/* XXX fail: */
printk(KERN_ERR "%s: Allocation failure during SCSI scanning, "
"some SCSI devices might not be configured\n",
__FUNCTION__);
--
Bob Miller Email: rem@osdl.org
Open Source Development Lab Phone: 503.626.2455 Ext. 17
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [TRIVIAL PATCH 2.5.47] Remove compile warning from scsi/scsi.c
2002-11-13 22:27 [TRIVIAL PATCH 2.5.47] Remove compile warning from scsi/scsi.c Bob Miller
@ 2002-12-02 3:57 ` Rusty Russell
0 siblings, 0 replies; 2+ messages in thread
From: Rusty Russell @ 2002-12-02 3:57 UTC (permalink / raw)
To: Bob Miller; +Cc: linux-kernel
In message <20021113222709.GB3336@doc.pdx.osdl.net> you write:
> diff -Nru a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c
> --- a/drivers/scsi/scsi.c Wed Nov 13 14:09:57 2002
> +++ b/drivers/scsi/scsi.c Wed Nov 13 14:09:57 2002
> @@ -1985,7 +1985,7 @@
> up_read(&scsi_devicelist_mutex);
> return 0;
>
> -fail:
> +/* XXX fail: */
> printk(KERN_ERR "%s: Allocation failure during SCSI scanning, "
> "some SCSI devices might not be configured\n",
> __FUNCTION__);
That code is now unreachable, which can't be right.
(Catching up on trivial),
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-12-02 5:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-11-13 22:27 [TRIVIAL PATCH 2.5.47] Remove compile warning from scsi/scsi.c Bob Miller
2002-12-02 3:57 ` Rusty Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).