From: Russell King <rmk@arm.linux.org.uk>
To: John Bradford <john@grabjohn.com>
Cc: linux-kernel@vger.kernel.org, greg@kroah.com
Subject: Re: [RFC] add module reference to struct tty_driver
Date: Wed, 15 Jan 2003 10:40:16 +0000 [thread overview]
Message-ID: <20030115104016.E31372@flint.arm.linux.org.uk> (raw)
In-Reply-To: <200301151030.h0FAU3ox000873@darkstar.example.net>; from john@grabjohn.com on Wed, Jan 15, 2003 at 10:30:03AM +0000
On Wed, Jan 15, 2003 at 10:30:03AM +0000, John Bradford wrote:
> > > Woah! Hm, this is going to cause lots of problems in drivers that have
> > > been assuming that the BKL is grabbed during module unload, and during
> > > open(). Hm, time to just fallback on the argument, "module unloading is
> > > unsafe" :(
> >
> > Note that its the same in 2.4 as well. iirc, the BKL was removed from
> > module loading/unloading sometime in the 2.3 timeline.
>
> Surely no recent code should be making that assumption anyway - the
> BKL is being removed all over the place.
The TTY layer isn't "recent code", its "very old code", and (IMO)
removing the BKL from the TTY layer is a far from trivial matter.
I believe at this point in the 2.5 cycle, we should not be looking
to remove the BKL. We should be looking to fix the problems we know
about. That basically means:
- module refcounting
- interrupt races
- any other races (eg, tty_register_driver / tty_unregister_driver)
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next prev parent reply other threads:[~2003-01-15 10:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-13 5:47 [RFC] add module reference to struct tty_driver Greg KH
2003-01-13 9:27 ` Russell King
2003-01-13 17:12 ` Greg KH
2003-01-13 19:51 ` Max Krasnyansky
2003-01-14 20:07 ` Russell King
2003-01-14 22:08 ` Greg KH
2003-01-15 10:00 ` Russell King
2003-01-15 9:09 ` Henrique Gobbi
2003-01-15 10:30 ` John Bradford
2003-01-15 10:40 ` Russell King [this message]
2003-01-15 11:12 ` John Bradford
2003-01-15 16:03 ` Randy.Dunlap
2003-01-15 15:26 ` Kai Germaschewski
2003-01-15 16:31 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030115104016.E31372@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=greg@kroah.com \
--cc=john@grabjohn.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).