linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Bradford <john@grabjohn.com>
To: rmk@arm.linux.org.uk (Russell King)
Cc: linux-kernel@vger.kernel.org, greg@kroah.com
Subject: Re: [RFC] add module reference to struct tty_driver
Date: Wed, 15 Jan 2003 11:12:08 +0000 (GMT)	[thread overview]
Message-ID: <200301151112.h0FBC8l5000957@darkstar.example.net> (raw)
In-Reply-To: <20030115104016.E31372@flint.arm.linux.org.uk> from "Russell King" at Jan 15, 2003 10:40:16 AM

> > > > Woah!  Hm, this is going to cause lots of problems in drivers that have
> > > > been assuming that the BKL is grabbed during module unload, and during
> > > > open().  Hm, time to just fallback on the argument, "module
> > > > unloading is unsafe" :(
> > > 
> > > Note that its the same in 2.4 as well.  iirc, the BKL was removed from
> > > module loading/unloading sometime in the 2.3 timeline.
> > 
> > Surely no recent code should be making that assumption anyway - the
> > BKL is being removed all over the place.
> 
> The TTY layer isn't "recent code", its "very old code"

Oh, I know, I was just thinking aloud and not making much sense, ( :-)
) - what I really meant was is anybody writing new code without the
near-future BKL changes in mind, and if so, shouldn't it be avoided
now to save work in 2.7?  I.E. is the BKL officially depreciated?

> and (IMO) removing the BKL from the TTY layer is a far from trivial
> matter.
> 
> I believe at this point in the 2.5 cycle, we should not be looking
> to remove the BKL.

I think there were hints in another thread of a TTY layer overhaul in
2.7.

John.

  reply	other threads:[~2003-01-15 11:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-13  5:47 [RFC] add module reference to struct tty_driver Greg KH
2003-01-13  9:27 ` Russell King
2003-01-13 17:12   ` Greg KH
2003-01-13 19:51   ` Max Krasnyansky
2003-01-14 20:07 ` Russell King
2003-01-14 22:08   ` Greg KH
2003-01-15 10:00     ` Russell King
2003-01-15  9:09       ` Henrique Gobbi
2003-01-15 10:30       ` John Bradford
2003-01-15 10:40         ` Russell King
2003-01-15 11:12           ` John Bradford [this message]
2003-01-15 16:03           ` Randy.Dunlap
2003-01-15 15:26       ` Kai Germaschewski
2003-01-15 16:31       ` Roman Zippel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200301151112.h0FBC8l5000957@darkstar.example.net \
    --to=john@grabjohn.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).