From: Valdis.Kletnieks@vt.edu
To: Frank Davis <fdavis@si.rr.com>
Cc: linux-kernel@vger.kernel.org, trivial@rustcorp.com.au
Subject: Re: [PATCH] 2.5.59 : drivers/char/ip2/i2lib.c
Date: Fri, 07 Feb 2003 12:15:13 -0500 [thread overview]
Message-ID: <200302071715.h17HFD07006005@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Fri, 07 Feb 2003 12:17:45 EST." <Pine.LNX.4.44.0302071214440.6917-100000@master>
[-- Attachment #1: Type: text/plain, Size: 625 bytes --]
On Fri, 07 Feb 2003 12:17:45 EST, Frank Davis said:
> + if ((1 == i2QueueCommands(PTYPE_INLINE, pCh, 0, 1, CMD_STOPFL))
&& (i2QueueCommands(PTYPE_INLINE, pCh, 0, 1, CMD_STOPFL) > 0 )) {
Hmm... if ((1 == A) && (A > 0)) {
Unless i2QueueCommands has a side-effect on being re-evaluated (which isn't
guaranteed to happen), it looks like this can be simplified a bit,
since the '&& (A > 0)' is superfluous.
I think the code started as 'if A == 1' and became 'if A > 0', or vice
versa, and somebody needs to check what's *REALLY* intended...
--
Valdis Kletnieks
Computer Systems Senior Engineer
Virginia Tech
[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]
next prev parent reply other threads:[~2003-02-07 17:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-07 17:17 [PATCH] 2.5.59 : drivers/char/ip2/i2lib.c Frank Davis
2003-02-07 17:15 ` Valdis.Kletnieks [this message]
2003-02-10 0:27 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200302071715.h17HFD07006005@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=fdavis@si.rr.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).