From: Rusty Russell <rusty@rustcorp.com.au>
To: Frank Davis <fdavis@si.rr.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5.59 : drivers/char/ip2/i2lib.c
Date: Mon, 10 Feb 2003 11:27:24 +1100 [thread overview]
Message-ID: <20030210014641.206E42C0D1@lists.samba.org> (raw)
In-Reply-To: Your message of "Fri, 07 Feb 2003 12:17:45 CDT." <Pine.LNX.4.44.0302071214440.6917-100000@master>
In message <Pine.LNX.4.44.0302071214440.6917-100000@master> you write:
> Hello all,
> The following patch addresses buzilla bug # 320, and separates 1 test
> into 2 separate 2 tests. Please review for inclusion.
The old code was nonsensical, so I can't trivially tell if the new
code is right. This has to be done by the author.
With no '@' sign anywhere in the char/ip2 subdirectory, I have no idea
who to send this to 8(
Rusty.
> --- linux/drivers/char/ip2/i2lib.c.old 2003-01-16 21:22:57.000000000 -0500
> +++ linux/drivers/char/ip2/i2lib.c 2003-02-07 02:54:36.000000000 -0500
> @@ -1251,7 +1251,7 @@
>
> }
> if ( old_flags & STOPFL_FLAG ) {
> - if ( 1 == i2QueueCommands(PTYPE_INLINE, pCh, 0, 1, CMD_STOPFL)
> 0 ) {
> + if ((1 == i2QueueCommands(PTYPE_INLINE, pCh, 0, 1, CMD_STOPFL)) && (i2QueueCommands(PTYPE_INLINE, pCh, 0, 1, CMD_STOPFL) > 0 )) {
> old_flags = 0; // Success - clear flags
> }
>
>
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
prev parent reply other threads:[~2003-02-10 1:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-07 17:17 [PATCH] 2.5.59 : drivers/char/ip2/i2lib.c Frank Davis
2003-02-07 17:15 ` Valdis.Kletnieks
2003-02-10 0:27 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030210014641.206E42C0D1@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=fdavis@si.rr.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).