From: Russell King <rmk@arm.linux.org.uk>
To: Frank Davis <fdavis@si.rr.com>
Cc: linux-kernel@vger.kernel.org, trivial@rustcorp.com.au
Subject: Re: [PATCH] 2.5.59 : sound/oss/vidc.c
Date: Fri, 7 Feb 2003 19:43:14 +0000 [thread overview]
Message-ID: <20030207194314.C30927@flint.arm.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.44.0302071211390.6917-100000@master>; from fdavis@si.rr.com on Fri, Feb 07, 2003 at 12:13:04PM -0500
On Fri, Feb 07, 2003 at 12:13:04PM -0500, Frank Davis wrote:
> Hello all,
> The following patch addresses buzilla bug # 318, and removes an
> offending semicolon. Please review for inclusion.
>
> Regards,
> Frank
>
> --- linux/sound/oss/vidc.c.old 2003-01-16 21:21:38.000000000 -0500
> +++ linux/sound/oss/vidc.c 2003-02-07 02:59:44.000000000 -0500
> @@ -225,7 +225,7 @@
> newsize = 208;
> if (newsize > 4096)
> newsize = 4096;
> - for (new2size = 128; new2size < newsize; new2size <<= 1);
> + for (new2size = 128; new2size < newsize; new2size <<= 1)
> if (new2size - newsize > newsize - (new2size >> 1))
> new2size >>= 1;
> if (new2size > 4096) {
The code is correct as it originally stood.
It looks like indent has a bug and incorrectly formats this to look wrong.
Back in 2.2 times, the code looks like this:
for (new2size = 128; new2size < newsize; new2size <<= 1);
if (new2size - newsize > newsize - (new2size >> 1))
new2size >>= 1;
and this is the intended functionality. Please do NOT apply the patch.
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next prev parent reply other threads:[~2003-02-07 19:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-07 17:13 [PATCH] 2.5.59 : sound/oss/vidc.c Frank Davis
2003-02-07 19:43 ` Russell King [this message]
2003-02-07 20:03 ` John Bradford
2003-02-07 20:47 ` Richard B. Johnson
2003-02-07 21:58 ` J.A. Magallon
2003-02-07 22:20 ` Russell King
2003-02-07 22:35 ` John Bradford
2003-02-10 22:03 ` Bill Davidsen
2003-02-11 7:49 ` Horst von Brand
2003-02-07 23:54 ` Alan Cox
2003-02-10 0:23 ` Rusty Russell
2003-02-08 0:37 Alexei Podtelezhnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030207194314.C30927@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=fdavis@si.rr.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).