From: Alexei Podtelezhnikov <apodtele@mccammon.ucsd.edu>
To: john@grabjohn.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5.59 : sound/oss/vidc.c
Date: Fri, 7 Feb 2003 16:37:25 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.44.0302071608410.18936-100000@chemcca61.ucsd.edu> (raw)
John Bradford (john@grabjohn.com) wrote:
> 36 < hwrate < 3332
^^^^^^ should be 'newsize'
Yeap, and the following couple of lines:
/* 36 < newsize 3332; rounding it off
* to the nearest power of 2, no less than 256
*/
for (new2size = 384; new2size < newsize; new2size <<= 1);
new2size -= (new2size >> 1);
safely replace the whole following block:
if (newsize < 208)
newsize = 208;
if (newsize > 4096)
newsize = 4096;
for (new2size = 128; new2size < newsize; new2size <<= 1);
if (new2size - newsize > newsize - (new2size >> 1))
new2size >>= 1;
if (new2size > 4096) {
printk(KERN_ERR "VIDC: error: dma buffer (%d) %d > 4K\n",
newsize, new2size);
new2size = 4096;
}
Would somebody test this?
A.
next reply other threads:[~2003-02-08 0:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-08 0:37 Alexei Podtelezhnikov [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-02-07 17:13 [PATCH] 2.5.59 : sound/oss/vidc.c Frank Davis
2003-02-07 19:43 ` Russell King
2003-02-07 20:03 ` John Bradford
2003-02-07 20:47 ` Richard B. Johnson
2003-02-07 21:58 ` J.A. Magallon
2003-02-07 22:20 ` Russell King
2003-02-07 22:35 ` John Bradford
2003-02-10 22:03 ` Bill Davidsen
2003-02-11 7:49 ` Horst von Brand
2003-02-07 23:54 ` Alan Cox
2003-02-10 0:23 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0302071608410.18936-100000@chemcca61.ucsd.edu \
--to=apodtele@mccammon.ucsd.edu \
--cc=john@grabjohn.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).