* Re: [PATCH] 2.5.59 : sound/oss/vidc.c (CORRECTED)
@ 2003-02-08 0:45 Alexei Podtelezhnikov
2003-02-08 11:25 ` John Bradford
0 siblings, 1 reply; 2+ messages in thread
From: Alexei Podtelezhnikov @ 2003-02-08 0:45 UTC (permalink / raw)
To: john; +Cc: linux-kernel
John Bradford (john@grabjohn.com) wrote:
> 36 < hwrate < 3332
^^^^^^ should be 'newsize'
Yeap, and the following couple of lines:
/* 36 < newsize 3332; rounding it off
* to the nearest power of 2, no less than 256
*/
for (new2size = 384; new2size < newsize; new2size <<= 1);
new2size -= new2size / 3;
safely replace the whole following block:
if (newsize < 208)
newsize = 208;
if (newsize > 4096)
newsize = 4096;
for (new2size = 128; new2size < newsize; new2size <<= 1);
if (new2size - newsize > newsize - (new2size >> 1))
new2size >>= 1;
if (new2size > 4096) {
printk(KERN_ERR "VIDC: error: dma buffer (%d) %d > 4K\n",
newsize, new2size);
new2size = 4096;
}
Would somebody test this?
A.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] 2.5.59 : sound/oss/vidc.c (CORRECTED)
2003-02-08 0:45 [PATCH] 2.5.59 : sound/oss/vidc.c (CORRECTED) Alexei Podtelezhnikov
@ 2003-02-08 11:25 ` John Bradford
0 siblings, 0 replies; 2+ messages in thread
From: John Bradford @ 2003-02-08 11:25 UTC (permalink / raw)
To: Alexei Podtelezhnikov; +Cc: linux-kernel, rmk
>
> John Bradford (john@grabjohn.com) wrote:
>
> > 36 < hwrate < 3332
> ^^^^^^ should be 'newsize'
>
> Yeap, and the following couple of lines:
>
> /* 36 < newsize 3332; rounding it off
> * to the nearest power of 2, no less than 256
> */
> for (new2size = 384; new2size < newsize; new2size <<= 1);
> new2size -= new2size / 3;
>
> safely replace the whole following block:
>
> if (newsize < 208)
> newsize = 208;
> if (newsize > 4096)
> newsize = 4096;
> for (new2size = 128; new2size < newsize; new2size <<= 1);
> if (new2size - newsize > newsize - (new2size >> 1))
> new2size >>= 1;
> if (new2size > 4096) {
> printk(KERN_ERR "VIDC: error: dma buffer (%d) %d > 4K\n",
> newsize, new2size);
> new2size = 4096;
> }
>
> Would somebody test this?
The only change I'd make would be:
- /* 36 < newsize 3332; rounding it off
+ /* 36 <= newsize <= 3332; rounding it off
John
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-02-08 11:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-02-08 0:45 [PATCH] 2.5.59 : sound/oss/vidc.c (CORRECTED) Alexei Podtelezhnikov
2003-02-08 11:25 ` John Bradford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).