routing oddity in 2.5.59-mm8

routing oddity in 2.5.59-mm8

[Florian Schmitt]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

in 2.5.59-mm8 the routing table behaves a bit strange:

# > route
Kernel IP routing table
Destination     Gateway         Genmask         Flags Metric Ref    Use Iface
rtsl-stgt-de01. *               255.255.255.255 UH    0      0        0 ppp0
192.168.1.0     *               255.255.255.0   U     0      0        0 eth0

In 2.5.59-linus an additional default route is shown. If I try to add my 
default route, I get:

# > route add -net 0.0.0.0 netmask 0.0.0.0 dev ppp0 gw 213.20.223.152
SIOCADDRT: File exists
# > route 
Kernel IP routing table
Destination     Gateway         Genmask         Flags Metric Ref    Use Iface
rtsl-stgt-de01. *               255.255.255.255 UH    0      0        0 ppp0
192.168.1.0     *               255.255.255.0   U     0      0        0 eth0

Nothing has changed. The route seems to be there (but invisible), because I 
can access other subnets through the gateway.

- --
Flo

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)
Comment: You may find my public key at http://www.galois.de/florian.schmitt.pubkey.asc

iD8DBQE+RjNLH7Gei80C0lQRAqWEAKC4az6znXaYRL04UMX1NkfPP/5UQwCgqvcW
QeDgvLbRwHvERLD78qoK8vA=
=JSv7
-----END PGP SIGNATURE-----

Re: routing oddity in 2.5.59-mm8

[Andrew Morton]

Florian Schmitt <florian@galois.de> wrote:
>
> in 2.5.59-mm8 the routing table behaves a bit strange:

me too:

vmm:/home/akpm# ip route show
192.168.2.0/24 dev eth0  scope link 
127.0.0.0/8 dev lo  scope link 
default via 192.168.2.1 dev eth0 
vmm:/home/akpm# route -n
Kernel IP routing table
Destination     Gateway         Genmask         Flags Metric Ref    Use Iface
192.168.2.0     0.0.0.0         255.255.255.0   U     0      0        0 eth0
127.0.0.0       0.0.0.0         255.0.0.0       U     0      0        0 lo
vmm:/home/akpm# route del default
vmm:/home/akpm# route del default
SIOCDELRT: No such process

So `ip' can see the default route, but `route' cannot.

Reverting the spurious semicolon fix fixes it up.

diff -puN net/ipv4/fib_hash.c~a net/ipv4/fib_hash.c
--- 25/net/ipv4/fib_hash.c~a	2003-02-09 03:04:29.000000000 -0800
+++ 25-akpm/net/ipv4/fib_hash.c	2003-02-09 03:04:32.000000000 -0800
@@ -941,7 +941,7 @@ static __inline__ struct fib_node *fib_g
 
 			if (!iter->zone)
 				goto out;
-			if (iter->zone->fz_next)
+			if (iter->zone->fz_next);
 				break;
 		}
 		

_