linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* RE: [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (16/21) SCSI
@ 2003-02-24  7:52 Osamu Tomita
  2003-02-24 13:59 ` Osamu Tomita
  0 siblings, 1 reply; 6+ messages in thread
From: Osamu Tomita @ 2003-02-24  7:52 UTC (permalink / raw)
  To: 'Christoph Hellwig '
  Cc: 'Linux Kernel Mailing List ', 'Alan Cox '

-----Original Message-----
From: Christoph Hellwig
To: Osamu Tomita
Cc: Linux Kernel Mailing List; Alan Cox; Christoph Hellwig
Sent: 2003/02/23 19:52
Subject: Re: [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (16/21) SCSI

>> +int pc98_bios_param(struct block_device *bdev, int *ip)
>> +{
>> +  /* Note: This function is called from fs/partitions/nec98.c too. */
>> +  /* So we creat 'sdp' from 'bdev' here. */
>> +  struct scsi_disk *sdkp = scsi_disk(bdev->bd_disk);
> 
> this is still not good - you shouldn't expose struct scsi_disk outside
> sd.c.  Please change the pc98_bios_param() prototype to that of the
> bios_param entry point (direct passing of capacity).
This is solved by using ioctl_by_bdev() in your suggestion. Thanks.

> Can you explain what this first_real_host() stuff is for - we need some
> way to handle this better.
PC98 BIOS create geometry table on boottime orderd by SCSI ID.
We read that to get geometry. If ide-scsi exist we mis-read table.

.
.
(Snipped, but I'll fix them. Thanks.)
.
.


>> +	BIOS_PARAM_OVERRIDE(sdp, bdev, sdkp->capacity, diskinfo);
>> +
> 
> the way this is done is ugly.  I'm still not sure how this is done
> best.  When do you need the pc98 geometry exactly?  i.e. can it happen
> with one of the existing linux scsi drivers?
We need BIOS geometry exactly to create a partion on linux (by fdisk or
GNU/parted). BIOS uses C/H/S access on boottime according to partition
table. If BIOS geometry is not exact, fail to boot from the partition.
I recived the report about this problem from people using advansys driver
without PC98 patch.

>> +#if defined(CONFIG_SCSI_PC980155) ||
defined(CONFIG_SCSI_PC980155_MODULE)
>> +#include "pc980155regs.h"
>> +#else /* !CONFIG_SCSI_PC980155 */
>>  
>>  static inline uchar read_wd33c93(const wd33c93_regs regs, uchar
reg_num)
>>  {
>> @@ -203,6 +206,7 @@
>>     *regs.SCMD = cmd;
>>     mb();
>>  }
>> +#endif /* CONFIG_SCSI_PC980155 */
> 
> The wd33c93 changes are ugly as hell, but that's not your fault.  I'll
> try to rework it to abstract out the different implementations better.
> Could you perform some testing for me if I send you updated versions?
Yes, of course.

Thanks,
Osamu Tomita

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (0/21) summary
@ 2003-02-23  9:21 Osamu Tomita
  2003-02-23  9:55 ` [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (16/21) SCSI Osamu Tomita
  0 siblings, 1 reply; 6+ messages in thread
From: Osamu Tomita @ 2003-02-23  9:21 UTC (permalink / raw)
  To: Linux Kernel Mailing List; +Cc: Linus Torvalds, Alan Cox

This is additional patch to support NEC PC-9800 subarchitecture
against 2.5.62-ac1.

You can get whole patchset from URL below.
http://downloads.sourceforge.jp/linux98/2469/linux98-2.5.62-ac1.patch.tar.bz2
Comments and test reports are wellcome.

Description:
 o alsa-pc98.patch (1/21)
   ALSA sound drivers for PC98.
 o apm.patch (2/21)
   APM support for PC98. Including PC98's BIOS bug fix.
 o console.patch (3/21)
   PC98 Standard console support (without japanese kanji character).
 o core-misc.patch (4/21)
   Small core patches for PC98.
 o dma.patch (5/21)
   DMA support for PC98.
 o fs.patch (6/21)
   FAT fs and partition table support for PC98.
 o ide.patch (7/21)
   PC98 standard IDE I/F support.
 o kanji.patch (8/21)
   japanese kanji character support for PC98 console.
 o kconfig.patch (9/21)
   Add selection CONFIG_X86_PC9800.
 o network_card.patch (10/21)
   C-bus(PC98's legacy bus like ISA) network cards support.
 o parport.patch (11/21)
   Parallel port support.
 o pci.patch (12/21)
   Small changes for PCI support.
 o pcmcia.patch (13/21)
   Small change for PCMCIA (16bits) support.
 o pnp.patch (14/21)
   Small change for Legacy bus PNP support.
 o rtc.patch (15/21)
   Support RTC for PC98, using mach-* scheme.
 o scsi.patch (16/21)
   SCSI host adapter support.
 o serial.patch (17/21)
   Serial port support for PC98.
 o setup.patch (18/21)
   Support difference of IO port/memory address, using mach-* scheme.
 o smp.patch (19/21)
   SMP support for PC98.
 o timer.patch (20/21)
   Support difference of timer, using mach-* scheme.
 o traps.patch (21/21)
   Support difference of NMI handling, using mach-* scheme.

Thanks,
Osamu Tomita <tomita@cinet.co.jp>


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2003-03-09  2:21 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-02-24  7:52 [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (16/21) SCSI Osamu Tomita
2003-02-24 13:59 ` Osamu Tomita
2003-03-06 10:44   ` Geert Uytterhoeven
2003-03-09  2:31     ` Osamu Tomita
  -- strict thread matches above, loose matches on Subject: below --
2003-02-23  9:21 [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (0/21) summary Osamu Tomita
2003-02-23  9:55 ` [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (16/21) SCSI Osamu Tomita
2003-02-23 10:52   ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).