From: Dominik Brodowski <linux@brodo.de>
To: mochel@osdl.org
Cc: torvalds@transmeta.com, jt@hpl.hp.com,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
mika.penttila@kolumbus.fi
Subject: Re: [PATCH] pcmcia: get initialization ordering right [Was: [PATCH 2.5] : i82365 & platform_bus_type]
Date: Tue, 4 Mar 2003 10:54:47 +0100 [thread overview]
Message-ID: <20030304095447.GA1408@brodo.de> (raw)
In-Reply-To: <20030304083031.JEP4145.fep02-app.kolumbus.fi@[193.229.5.109]>
Hi Pat,
How is it supposed to work then? I thought adding a platform_device and
platform_driver with the same name and bus_id causes the platform_driver to
be bound to the platform_device?
Thanks,
Dominik
On Tue, Mar 04, 2003 at 10:30:31AM +0200, mika.penttila@kolumbus.fi wrote:
> I think the problem is platform_match() :
>
> static int platform_match(struct device * dev, struct device_driver * drv)
> {
> return 0;
> }
>
> which effectively makes driver binding impossible, pcmcia_socket_class->add_device isn't called.
>
> --Mika
>
>
> >
> > Lähettäjä: Dominik Brodowski <linux@brodo.de>
> > Päiväys: 2003/03/04 ti AM 09:39:15 GMT+02:00
> > Vastaanottaja: torvalds@transmeta.com, jt@hpl.hp.com
> > Kopio: Linux kernel mailing list <linux-kernel@vger.kernel.org>,
> > Patrick Mochel <mochel@osdl.org>
> > Aihe: [PATCH] pcmcia: get initialization ordering right [Was: [PATCH 2.5] : i82365 & platform_bus_type]
> >
> > Hi,
> >
> > On Mon, Mar 03, 2003 at 05:30:20PM -0800, Jean Tourrilhes wrote:
> > > Hi,
> > >
> > > I'm trying to get i82365 to work again, because I need to test
> > <snip>
> > > Intel PCIC probe:
> > > Vadem VG-469 ISA-to-PCMCIA at port 0x3e0 ofs 0x00, 2 sockets
> > > host opts [0]: none
> > > host opts [1]: none
> > > ISA irqs (scanned) = 4,5 polling interval = 1000 ms
> > > ds: no socket drivers loaded!
> >
> > Sorry about that -- I mixed up the ordering of initializing the class data
> > and registering the platform device. Here's a bugfix for the three pcmcia
> > socket drivers that are platform devices.
> >
> > Please apply,
> > Dominik
> >
> > diff -ruN linux-original/drivers/pcmcia/hd64465_ss.c linux/drivers/pcmcia/hd64465_ss.c
> > --- linux-original/drivers/pcmcia/hd64465_ss.c 2003-03-04 08:27:06.000000000 +0100
> > +++ linux/drivers/pcmcia/hd64465_ss.c 2003-03-04 08:30:37.000000000 +0100
> > @@ -1070,8 +1070,8 @@
> > }
> >
> > /* hd64465_io_debug = 0; */
> > - platform_device_register(&hd64465_device);
> > hd64465_device.dev.class_data = &hd64465_data;
> > + platform_device_register(&hd64465_device);
> >
> > return 0;
> > }
> > diff -ruN linux-original/drivers/pcmcia/i82365.c linux/drivers/pcmcia/i82365.c
> > --- linux-original/drivers/pcmcia/i82365.c 2003-03-04 08:27:06.000000000 +0100
> > +++ linux/drivers/pcmcia/i82365.c 2003-03-04 08:28:28.000000000 +0100
> > @@ -1628,11 +1628,11 @@
> > request_irq(cs_irq, pcic_interrupt, 0, "i82365", pcic_interrupt);
> > #endif
> >
> > - platform_device_register(&i82365_device);
> > -
> > i82365_data.nsock = sockets;
> > i82365_device.dev.class_data = &i82365_data;
> >
> > + platform_device_register(&i82365_device);
> > +
> > /* Finally, schedule a polling interrupt */
> > if (poll_interval != 0) {
> > poll_timer.function = pcic_interrupt_wrapper;
> > diff -ruN linux-original/drivers/pcmcia/tcic.c linux/drivers/pcmcia/tcic.c
> > --- linux-original/drivers/pcmcia/tcic.c 2003-03-04 08:27:06.000000000 +0100
> > +++ linux/drivers/pcmcia/tcic.c 2003-03-04 08:30:03.000000000 +0100
> > @@ -452,8 +452,6 @@
> > sockets++;
> > }
> >
> > - platform_device_register(&tcic_device);
> > -
> > switch (socket_table[0].id) {
> > case TCIC_ID_DB86082:
> > printk("DB86082"); break;
> > @@ -527,6 +525,8 @@
> > tcic_data.nsock = sockets;
> > tcic_device.dev.class_data = &tcic_data;
> >
> > + platform_device_register(&tcic_device);
> > +
> > return 0;
> >
> > } /* init_tcic */
> > -
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
> >
>
next prev parent reply other threads:[~2003-03-04 9:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-04 8:30 [PATCH] pcmcia: get initialization ordering right [Was: [PATCH 2.5] : i82365 & platform_bus_type] mika.penttila
2003-03-04 9:54 ` Dominik Brodowski [this message]
2003-03-04 14:35 ` Patrick Mochel
2003-03-04 17:16 ` Jean Tourrilhes
2003-03-04 17:48 ` Patrick Mochel
2003-03-04 18:54 ` Jean Tourrilhes
2003-03-04 19:47 ` Dominik Brodowski
2003-03-05 6:39 ` [PATCH] driver model: fix platform_match [Was: Re: [PATCH] pcmcia: get initialization ordering right [Was: [PATCH 2.5] : i82365 & platform_bus_type]] Dominik Brodowski
2003-03-05 16:16 ` Patrick Mochel
2003-03-15 2:03 ` Jean Tourrilhes
-- strict thread matches above, loose matches on Subject: below --
2003-03-04 1:30 [PATCH 2.5] : i82365 & platform_bus_type Jean Tourrilhes
2003-03-04 7:39 ` [PATCH] pcmcia: get initialization ordering right [Was: [PATCH 2.5] : i82365 & platform_bus_type] Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030304095447.GA1408@brodo.de \
--to=linux@brodo.de \
--cc=jt@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.penttila@kolumbus.fi \
--cc=mochel@osdl.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).