From: Jean Tourrilhes <jt@bougret.hpl.hp.com>
To: Patrick Mochel <mochel@osdl.org>
Cc: Dominik Brodowski <linux@brodo.de>,
torvalds@transmeta.com,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
mika.penttila@kolumbus.fi
Subject: Re: [PATCH] pcmcia: get initialization ordering right [Was: [PATCH 2.5] : i82365 & platform_bus_type]
Date: Tue, 4 Mar 2003 10:54:28 -0800 [thread overview]
Message-ID: <20030304185428.GA16945@bougret.hpl.hp.com> (raw)
In-Reply-To: <Pine.LNX.4.33.0303041123210.992-100000@localhost.localdomain>
On Tue, Mar 04, 2003 at 11:48:22AM -0600, Patrick Mochel wrote:
>
> Surely you're sore that your code has required some modifications since
> Dominik has started working on PCMCIA, and I'm sure that no harm was
> intended. It's had some bumps, but IMO, he's done a great job, and the
> result is a vast improvement. The least you could is give the guy some
> slack, instead of whining about your own inconveniences.
I don't mind the changes, changes are usually good. In 2.5.X,
I had to change my code to accomodate the new PCI interface, the
removal of global IRQ, the new module interface, the various USB API
changes and other changes. And actually, your work currently hasn't
had any impact on the source code I follow (yet).
What I mind is the lack of basic testing. From your patch, the
initialisation order mixup and the other obvious bug fix I sent you,
this code had zero chances of working at all and it's obvious that
nobody bothered to check if it could work or not for at least two
kernel releases.
Yeah, I know that I should not complain because at least the
code did compile (modulo other minor obvious fixes that are already in
Linus BK).
> Thanks,
>
> -pat
Have fun...
Jean
next prev parent reply other threads:[~2003-03-04 18:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-04 8:30 [PATCH] pcmcia: get initialization ordering right [Was: [PATCH 2.5] : i82365 & platform_bus_type] mika.penttila
2003-03-04 9:54 ` Dominik Brodowski
2003-03-04 14:35 ` Patrick Mochel
2003-03-04 17:16 ` Jean Tourrilhes
2003-03-04 17:48 ` Patrick Mochel
2003-03-04 18:54 ` Jean Tourrilhes [this message]
2003-03-04 19:47 ` Dominik Brodowski
2003-03-05 6:39 ` [PATCH] driver model: fix platform_match [Was: Re: [PATCH] pcmcia: get initialization ordering right [Was: [PATCH 2.5] : i82365 & platform_bus_type]] Dominik Brodowski
2003-03-05 16:16 ` Patrick Mochel
2003-03-15 2:03 ` Jean Tourrilhes
-- strict thread matches above, loose matches on Subject: below --
2003-03-04 1:30 [PATCH 2.5] : i82365 & platform_bus_type Jean Tourrilhes
2003-03-04 7:39 ` [PATCH] pcmcia: get initialization ordering right [Was: [PATCH 2.5] : i82365 & platform_bus_type] Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030304185428.GA16945@bougret.hpl.hp.com \
--to=jt@bougret.hpl.hp.com \
--cc=jt@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@brodo.de \
--cc=mika.penttila@kolumbus.fi \
--cc=mochel@osdl.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).