From: chas williams <chas@locutus.cmf.nrl.navy.mil>
To: "David S. Miller" <davem@redhat.com>
Cc: wa@almesberger.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][ATM] make atm (and clip) modular + try_module_get()
Date: Wed, 05 Mar 2003 10:28:52 -0500 [thread overview]
Message-ID: <200303051528.h25FSqGi006413@locutus.cmf.nrl.navy.mil> (raw)
In-Reply-To: Your message of "Wed, 05 Mar 2003 06:53:41 PST." <20030305.065341.35361286.davem@redhat.com>
In message <20030305.065341.35361286.davem@redhat.com>,"David S. Miller" writes
:
>I understand why you think you have to lock, that isn't the issue.
>I'm telling you that you should be locking this crap at a much
>higher level.
ok, i see what you are saying now. since this is used to move the
stuff queued from the old connection to the new connection i suppose
clip might want something like?
spin_lock_bh(&vcc->recvq.lock)
skb_migrate(&vcc->recvq,©);
spin_unlock_bh(&vcc->recvq.lock);
that would block any more additions to the recvq (which should be
sk->receieve_queue i suspect -- more on that later) while the skb are
moved to copy. i am afraid i dont know much about how the clip driver
operates.
next prev parent reply other threads:[~2003-03-05 15:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-03 22:20 [PATCH][ATM] make atm (and clip) modular + try_module_get() chas williams
2003-03-03 22:26 ` chas williams
2003-03-04 0:28 ` Kai Germaschewski
2003-03-05 14:43 ` chas williams
2003-03-05 15:58 ` Kai Germaschewski
2003-03-05 16:05 ` chas williams
2003-03-05 16:11 ` Kai Germaschewski
2003-03-05 16:24 ` chas williams
2003-03-05 16:40 ` Kai Germaschewski
2003-03-05 16:26 ` Roman Zippel
2003-03-04 2:07 ` Werner Almesberger
2003-03-05 14:47 ` chas williams
2003-03-05 14:31 ` David S. Miller
2003-03-05 15:08 ` chas williams
2003-03-05 14:53 ` David S. Miller
2003-03-05 15:28 ` chas williams [this message]
2003-03-05 15:12 ` David S. Miller
2003-03-05 15:43 ` chas williams
2003-03-05 15:52 ` Werner Almesberger
2003-03-06 20:44 ` chas williams
2003-03-06 21:02 ` Werner Almesberger
2003-03-06 23:36 ` chas williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200303051528.h25FSqGi006413@locutus.cmf.nrl.navy.mil \
--to=chas@locutus.cmf.nrl.navy.mil \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wa@almesberger.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).