linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: chas williams <chas@locutus.cmf.nrl.navy.mil>
To: Werner Almesberger <wa@almesberger.net>
Cc: "David S. Miller" <davem@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][ATM] make atm (and clip) modular + try_module_get()
Date: Thu, 06 Mar 2003 15:44:07 -0500	[thread overview]
Message-ID: <200303062044.h26Ki7Gi013598@locutus.cmf.nrl.navy.mil> (raw)
In-Reply-To: Your message of "Wed, 05 Mar 2003 12:52:31 -0300." <20030305125230.B525@almesberger.net>

In message <20030305125230.B525@almesberger.net>,Werner Almesberger writes:
>native ATM VCs, owned by atmarpd. When atmarpd clears them for IP
>traffic, all the data that has been queued so far (i.e. any ATMARP
>messages, and any IP - typically I'd expect to find a SYN there)
>is removed from the native ATM VC's queue, and fed into the non-ATM
>part of the stack, for de-encapsulation, etc.

while you could make skb_migrate() generic, in this case it doesnt
really need to be.  since the dest list is on the stack you wouldn't
need to lock it -- only the source list.  however, this whole migrate
thing makes me a bit nervous.  you copy the pending data and then
requeue the data.  what keeps data from arriving on the vcc while
you are reprocessing -- this could lead to out of order packet
arrival.

perhaps the recvq could be locked (to prevent new arrivals) and then
go through and feed the ip traffic to clip_vcc() leaving the atmarp
traffic in the queue.  then, unlock and wakeup the vcc to force atmarp
to get the data pending for it (if any).  this would prevent get 
around the need to 'migrate' the data back and forth.


  reply	other threads:[~2003-03-06 20:34 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-03 22:20 [PATCH][ATM] make atm (and clip) modular + try_module_get() chas williams
2003-03-03 22:26 ` chas williams
2003-03-04  0:28 ` Kai Germaschewski
2003-03-05 14:43   ` chas williams
2003-03-05 15:58     ` Kai Germaschewski
2003-03-05 16:05       ` chas williams
2003-03-05 16:11         ` Kai Germaschewski
2003-03-05 16:24           ` chas williams
2003-03-05 16:40             ` Kai Germaschewski
2003-03-05 16:26       ` Roman Zippel
2003-03-04  2:07 ` Werner Almesberger
2003-03-05 14:47   ` chas williams
2003-03-05 14:31     ` David S. Miller
2003-03-05 15:08       ` chas williams
2003-03-05 14:53         ` David S. Miller
2003-03-05 15:28           ` chas williams
2003-03-05 15:12             ` David S. Miller
2003-03-05 15:43               ` chas williams
2003-03-05 15:52             ` Werner Almesberger
2003-03-06 20:44               ` chas williams [this message]
2003-03-06 21:02                 ` Werner Almesberger
2003-03-06 23:36                   ` chas williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200303062044.h26Ki7Gi013598@locutus.cmf.nrl.navy.mil \
    --to=chas@locutus.cmf.nrl.navy.mil \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wa@almesberger.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).